Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigate ok check #1179

Merged
merged 23 commits into from
Mar 19, 2020
Merged

Conversation

maxmarkus
Copy link
Contributor

Fixes #1174

@maxmarkus maxmarkus added the bug Something isn't working label Mar 19, 2020
@maxmarkus maxmarkus added this to the Hardening v1.0 milestone Mar 19, 2020
@JohannesDoberer JohannesDoberer self-assigned this Mar 19, 2020
@JohannesDoberer JohannesDoberer merged commit 827bd99 into SAP:master Mar 19, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Mar 19, 2020
* master:
  fix virtualTree to not add trailing slash at viewUrl (SAP#1172)
  Fix navigate ok check (SAP#1179)
  remove docsearch (SAP#1178)

# Conflicts:
#	test/e2e-test-application/package-lock.json
JohannesDoberer added a commit that referenced this pull request Mar 25, 2020
* master: (37 commits)
  Update deps to 0.7.7 (#1193)
  Document potential wrong-usage of context/dynamic nodes (#1155)
  travis fix
  version upate to v0.7.7 (#1186)
  Revert fallbackFrame okResponseHandler  (#1183)
  fix virtualTree to not add trailing slash at viewUrl (#1172)
  Fix navigate ok check (#1179)
  remove docsearch (#1178)
  Recalculation after cache deletion (#1173)
  Luigi Videos (#1060)
  Add hint to core functionality called early (#1130)
  Add implementations/scenarios (#1116)
  deleteCache was missing in contextswitcher (#1148)
  Update type descriptions (#1131)
  Route change loses context in contextswitcher (#1145)
  Debug cypress travis - parallel e2e tests (#1121)
  trying to run npm step only if triggered or pushed to master (#1139)
  Release v0.7.6 revert docs fiddle (#1138)
  travis fix
  travis fix
  ...

# Conflicts:
#	.travis.yml
#	CHANGELOG.md
#	client/luigi-client.d.ts
#	client/package-lock.json
#	client/package.json
#	client/public/package.json
#	client/src/linkManager.js
#	core/examples/luigi-sample-angular/src/assets/sampleexternal.html
#	core/package-lock.json
#	core/package.json
#	core/public/package.json
#	core/src/core-api/_internalLinkManager.js
#	core/src/core-api/baseClass.js
#	core/src/main.js
#	core/src/navigation/TopNav.html
#	docs/application-setup.md
#	docs/getting-started.md
#	docs/luigi-client-api.md
#	lerna.json
#	plugins/auth/src/auth-oidc/index.js
#	scripts/setup/angular.sh
#	scripts/setup/no-framework.sh
#	scripts/setup/openui5.sh
#	scripts/setup/vue.sh
#	test/e2e-test-application/e2e/tests/1-angular/navigation.spec.js
#	test/e2e-test-application/package-lock.json
#	test/e2e-test-application/package.json
#	test/e2e-test-application/src/app/project/dynamic/dynamic.component.ts
#	test/e2e-test-application/src/luigi-config/extended/auth.js
#	website/docs/package-lock.json
#	website/docs/package.json
#	website/fiddle/package.json
@maxmarkus maxmarkus deleted the 1174-fix-navigate-ok-check branch April 8, 2020 13:54
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Apr 14, 2020
* master:
  Release v1 (SAP#1201)
  Update deps to 0.7.7 (SAP#1193)
  Document potential wrong-usage of context/dynamic nodes (SAP#1155)
  travis fix
  version upate to v0.7.7 (SAP#1186)
  Revert fallbackFrame okResponseHandler  (SAP#1183)
  fix virtualTree to not add trailing slash at viewUrl (SAP#1172)
  Fix navigate ok check (SAP#1179)
  remove docsearch (SAP#1178)
  Recalculation after cache deletion (SAP#1173)
  Luigi Videos (SAP#1060)
  Add hint to core functionality called early (SAP#1130)
  Add implementations/scenarios (SAP#1116)
  deleteCache was missing in contextswitcher (SAP#1148)
  Update type descriptions (SAP#1131)
  Route change loses context in contextswitcher (SAP#1145)
  Debug cypress travis - parallel e2e tests (SAP#1121)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in luigi client navigation ok response check
2 participants