Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disableInputHelpers for globalsearch #1620

Merged
merged 12 commits into from
Sep 18, 2020
Merged

add disableInputHelpers for globalsearch #1620

merged 12 commits into from
Sep 18, 2020

Conversation

maxmarkus
Copy link
Contributor

Adds disableInputHandlers to globalSearch configuration, which allows disabling the search input event handlers.

globalSearch: {
  disableInputHandlers: true,
  searchProvider
},

@maxmarkus maxmarkus added the enhancement New feature or request label Sep 10, 2020
@maxmarkus maxmarkus added this to the Sprint 13 milestone Sep 10, 2020
@JohannesDoberer JohannesDoberer self-assigned this Sep 10, 2020
JohannesDoberer
JohannesDoberer approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 !

@ndricimrr ndricimrr self-assigned this Sep 14, 2020
ndricimrr
ndricimrr approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxmarkus maxmarkus merged commit 89c5ba6 into SAP:master Sep 18, 2020
@maxmarkus maxmarkus deleted the disableinputhelpers-for-globalsearch branch September 18, 2020 07:52
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 23, 2020
@JohannesDoberer
Merge branch 'master' into drawer
52fc3b0 
* master:
  add link (SAP#1630)
  Add NextJS example link (SAP#1632)
  Feature accordion categories (SAP#1623)
  add disableInputHelpers for globalsearch (SAP#1620)
  Show more - blog posts (SAP#1625)
  fix link to the callback section (SAP#1628)
  Fix modal content not displaying issue in Safari (SAP#1624)
@ndricimrr ndricimrr mentioned this pull request Oct 28, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@maxmarkus
add disableInputHelpers for globalsearch (SAP#1620)
d21abdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@JohannesDoberer JohannesDoberer

@ndricimrr ndricimrr

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.
3 participants
@maxmarkus @JohannesDoberer @ndricimrr