Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature accordion categories #1623

Merged
merged 13 commits into from
Sep 18, 2020
Merged

Feature accordion categories #1623

merged 13 commits into from
Sep 18, 2020

Conversation

azriel46d
Copy link
Contributor

Description

Changes proposed in this pull request:
In the navigation settings a Boolean to have only one category collapsed at any given time has been added. By default this is considered as false so that it keeps the functionality as is. Once toggled to true, the navigation acts as an accordion.

  • Updated LeftNav.html to listen to the variable
  • Updated the storeExpandedState helper to have a replace setting
  • Updated the documentation.
  • Added tests under navigation

@maxmarkus maxmarkus self-assigned this Sep 14, 2020
@maxmarkus
Merge branch 'feature-accordion-categories' of github.com:azriel46d/l…
de921ec 
…uigi into azriel46d-feature-accordion-categories
@JohannesDoberer JohannesDoberer added this to the Sprint 13 milestone Sep 14, 2020
@JohannesDoberer JohannesDoberer self-assigned this Sep 14, 2020
@maxmarkus maxmarkus added documentation documentation tasks enhancement New feature or request labels Sep 14, 2020
@alexandra-simeonova alexandra-simeonova self-assigned this Sep 14, 2020
maxmarkus
maxmarkus approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :-)

alexandra-simeonova
alexandra-simeonova reviewed Sep 15, 2020
View reviewed changes
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍
Just a small language suggestion (I hope I got the correct meaning)

docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
docs/navigation-parameters-reference.md Outdated Show resolved Hide resolved
JohannesDoberer
JohannesDoberer approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 !

@maxmarkus maxmarkus merged commit 8f28b65 into SAP:master Sep 18, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Sep 23, 2020
@JohannesDoberer
Merge branch 'master' into drawer
52fc3b0 
* master:
  add link (SAP#1630)
  Add NextJS example link (SAP#1632)
  Feature accordion categories (SAP#1623)
  add disableInputHelpers for globalsearch (SAP#1620)
  Show more - blog posts (SAP#1625)
  fix link to the callback section (SAP#1628)
  Fix modal content not displaying issue in Safari (SAP#1624)
@ndricimrr ndricimrr mentioned this pull request Oct 28, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@azriel46d
Feature accordion categories (SAP#1623)
9fa5214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

@alexandra-simeonova alexandra-simeonova

Labels
documentation documentation tasks enhancement New feature or request
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.
4 participants
@azriel46d @maxmarkus @JohannesDoberer @alexandra-simeonova