Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Auth API to allow dynamic logout #1631

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

dangrima90
Copy link
Contributor

Added a logout function in the Auth API so that one can logout the user dynamically.

Description

Changes proposed in this pull request:

  • Auth API has a new function logout() which allows logging the user out dynamically
  • Added separate spec file to test this functionality

@CLAassistant
Copy link

CLAassistant commented Sep 16, 2020

CLA assistant check
All committers have signed the CLA.

@JohannesDoberer JohannesDoberer added this to the Sprint 13 milestone Sep 17, 2020
@alexandra-simeonova alexandra-simeonova self-assigned this Sep 17, 2020
Copy link
Contributor

@alexandra-simeonova alexandra-simeonova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍

@JohannesDoberer JohannesDoberer self-assigned this Sep 18, 2020
@ndricimrr ndricimrr self-assigned this Sep 21, 2020
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@JohannesDoberer JohannesDoberer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ! Thx

@JohannesDoberer JohannesDoberer merged commit d491763 into SAP:master Sep 30, 2020
@JohannesDoberer JohannesDoberer added the enhancement New feature or request label Sep 30, 2020
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Oct 12, 2020
* master:
  bump the versions of luigi packages (SAP#1649)
  Add NodeAccessibilityResolver tip to auth document (SAP#1639)
  Adding funtionality to logout the user dynamically without the need to click the logout button (SAP#1631)
  fix issues with brken left side nav in semiCollapsed mode and scroller (SAP#1633)
  Add ids and aria-labeldby to the nested lists (SAP#1607)
  fixed nav hrefs for hash routing (SAP#1640)
@dangrima90 dangrima90 deleted the feature/logout-api branch October 21, 2020 11:16
@ndricimrr ndricimrr mentioned this pull request Oct 28, 2020
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants