Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed nav hrefs for hash routing #1640

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fixed nav hrefs for hash routing #1640

merged 1 commit into from
Sep 24, 2020

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Sep 24, 2020

No description provided.

@JohannesDoberer JohannesDoberer self-assigned this Sep 24, 2020
@JohannesDoberer JohannesDoberer added the bug Something isn't working label Sep 24, 2020
@JohannesDoberer JohannesDoberer added this to the Sprint 13 milestone Sep 24, 2020
maxmarkus
maxmarkus approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxmarkus maxmarkus self-assigned this Sep 24, 2020
ndricimrr
ndricimrr approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@ndricimrr ndricimrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JohannesDoberer JohannesDoberer merged commit 0aa0d87 into SAP:master Sep 24, 2020
@JohannesDoberer JohannesDoberer deleted the navhrefs_hashrouting branch September 24, 2020 18:39
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Oct 12, 2020
@JohannesDoberer
Merge branch 'master' into poc-refactor-drawer
bebfb67 
* master:
  bump the versions of luigi packages (SAP#1649)
  Add NodeAccessibilityResolver tip to auth document (SAP#1639)
  Adding funtionality to logout the user dynamically without the need to click the logout button (SAP#1631)
  fix issues with brken left side nav in semiCollapsed mode and scroller (SAP#1633)
  Add ids and aria-labeldby to the nested lists (SAP#1607)
  fixed nav hrefs for hash routing (SAP#1640)
@ndricimrr ndricimrr mentioned this pull request Oct 28, 2020
Merged
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@hardl
fixed nav hrefs for hash routing (SAP#1640)
80c2e31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@JohannesDoberer JohannesDoberer JohannesDoberer approved these changes

@ndricimrr ndricimrr ndricimrr approved these changes

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@stanleychh stanleychh Awaiting requested review from stanleychh

@UlianaMunich UlianaMunich Awaiting requested review from UlianaMunich

Assignees

@maxmarkus maxmarkus

@JohannesDoberer JohannesDoberer

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 13
Development

Successfully merging this pull request may close these issues.
4 participants
@hardl @maxmarkus @JohannesDoberer @ndricimrr