Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle init in luigi client without init handshake #994

Merged
merged 13 commits into from
Dec 5, 2019
Merged

handle init in luigi client without init handshake #994

merged 13 commits into from
Dec 5, 2019

Conversation

JohannesDoberer
Copy link
Contributor

No description provided.

@JohannesDoberer JohannesDoberer added this to the Sprint 8 milestone Nov 29, 2019
@JohannesDoberer JohannesDoberer added enhancement New feature or request WIP Work in progress and removed WIP Work in progress labels Nov 29, 2019
@JohannesDoberer
Merge branch 'master' into handle-init-in-luigi-client
c80b7b6 
* master:
  Update Luigi core npm to 6.13.1 (SAP#990)
  Update INTERNAL-README.md (SAP#987)
  Edge browser back (SAP#992)
@JohannesDoberer
no message
82a0553
@JohannesDoberer
Copy link
Contributor Author

For testing unzip and run these two folders on different webserver. May you have to change the port in the index files.
https://app.zenhub.com/files/139590701/4fc8897b-242d-4f60-b927-7eedf5f1527a/download

@alexandra-simeonova alexandra-simeonova self-assigned this Dec 2, 2019
@maxmarkus maxmarkus self-assigned this Dec 2, 2019
@zarkosimic zarkosimic self-assigned this Dec 2, 2019
zarkosimic
zarkosimic approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@zarkosimic zarkosimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@JohannesDoberer
no message
1e96f7c
@JohannesDoberer
Merge branch 'master' into handle-init-in-luigi-client
774e8af 
* master:
  improve evergreen bundle-size by using terser, added webpack analyze command (SAP#996)
@JohannesDoberer JohannesDoberer merged commit 7dcf290 into SAP:master Dec 5, 2019
@JohannesDoberer JohannesDoberer deleted the handle-init-in-luigi-client branch December 5, 2019 14:05
JohannesDoberer added a commit to JohannesDoberer/luigi that referenced this pull request Dec 5, 2019
@JohannesDoberer
Merge branch 'master' into custom-item-renderer-for-options-in-contex…
fdc3518 
…t-switcher

* master:
  CM-cookie-poisoning (SAP#1006)
  handle init in luigi client without init handshake (SAP#994)
  improve evergreen bundle-size by using terser, added webpack analyze command (SAP#996)
stanleychh pushed a commit to stanleychh/luigi that referenced this pull request Dec 30, 2021
@JohannesDoberer
handle init in luigi client without init handshake (SAP#994)
a5d2466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxmarkus maxmarkus maxmarkus approved these changes

@zarkosimic zarkosimic zarkosimic approved these changes

@alexandra-simeonova alexandra-simeonova alexandra-simeonova approved these changes

@bszwarc bszwarc Awaiting requested review from bszwarc

@hardl hardl Awaiting requested review from hardl hardl is a code owner

@kazydek kazydek Awaiting requested review from kazydek

@majakurcius majakurcius Awaiting requested review from majakurcius

@marynaKhromova marynaKhromova Awaiting requested review from marynaKhromova

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@pekura pekura Awaiting requested review from pekura

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

Assignees

@maxmarkus maxmarkus

@zarkosimic zarkosimic

@alexandra-simeonova alexandra-simeonova

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging this pull request may close these issues.
4 participants
@JohannesDoberer @maxmarkus @zarkosimic @alexandra-simeonova