Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet core SDK 3.0.100-preview7-012821 #92

Merged
merged 1 commit into from
Aug 4, 2019
Merged

dotnet core SDK 3.0.100-preview7-012821 #92

merged 1 commit into from
Aug 4, 2019

Conversation

SIkebe
Copy link
Owner

@SIkebe SIkebe commented Jul 25, 2019 •
edited
Loading

Fixes #91

  • netcoreapp2.1 -> netcoreapp3.0
  • netstandard2.0 -> netstandard2.1
  • NullableContextOptions -> Nullable
  • Skip In-Memory DB tests
  • Cake 0.33.0 -> 0.34.1

@SIkebe
dotnet core SDK 3.0.100-preview7-012821
49086f1 
* netcoreapp2.1 -> netcoreapp3.0
* netstandard2.0 -> netstandard2.1
* NullableContextOptions -> Nullable
* Skip In-Memory DB tests
* Cake 0.33.0 -> 0.34.1
@SIkebe SIkebe added the enhancement New feature or request label Jul 25, 2019
@SIkebe SIkebe added this to the v0.7.0 milestone Jul 25, 2019
@SIkebe SIkebe self-assigned this Jul 25, 2019
SIkebe
SIkebe commented Jul 25, 2019
View reviewed changes
Directory.Build.props
@@ -2,7 +2,7 @@

<PropertyGroup>
<LangVersion>8.0</LangVersion>
<NullableContextOptions>enable</NullableContextOptions>
<Nullable>enable</Nullable>
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Searching for references...

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dotnet/roslyn#35516

src/GitBucket.Service.Tests/ReleaseServicetest.cs
@@ -36,7 +37,7 @@ public async void Milestone_Has_No_Issue()
Assert.Equal("There are no issues related to \"v1.0.0\".", FakeConsole.WarnMessages[0]);
}

[Fact]
[Fact(Skip = "In-Memory DB is not available.")]
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all In-Memory DB tests are failing. Searching for related issues/

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#93

src/GitBucket.Service.Tests/ReleaseServicetest.cs
@@ -13,7 +13,8 @@ public class ReleaseServiceTest
{
public FakeConsole FakeConsole { get; } = new FakeConsole("yes");

[Fact]
#pragma warning disable xUnit1004 // Test methods should not be skipped
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only temporary.

@SIkebe SIkebe merged commit 329eb0b into develop Aug 4, 2019
@SIkebe SIkebe deleted the feature/3.0-preview7 branch August 4, 2019 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@SIkebe SIkebe

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

.NET Core 3.0 Preview 7
1 participant
@SIkebe