Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'Nullable' for Csc Task property #35516

Merged
merged 2 commits into from
May 6, 2019
Merged

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented May 4, 2019

Fixes #35432 based on LDM decision earlier this week.

Note: I left the compilation option and enum named NullableContextOptions.

@jcouv jcouv requested a review from a team as a code owner May 4, 2019 04:34
@jcouv jcouv self-assigned this May 4, 2019
@AlekseyTs
Copy link
Contributor

It looks like docs\features\nullable-reference-types.md should be adjusted as well.

Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1), modulo the nullable-reference-types.md update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change msbuild property to "Nullable"
3 participants