Four Kitchens Release - Sprint 39

[cienvaras]

READY FOR REVIEW

Summary

• SHS-5130: Implementation: Add <hr> tag to Color Band if no text
• SHS-5113: Editorially Customizations
• SHS-5119: Bug: Gray overlay (z-index issue?) on Manage Layout when clicking Configure for a field or block
• SHS-5095: Need better UI/theme around login page
• SHS-5148: Bug: hb-categories link hover style generally missing underline on last line
• SHS-5086: Add the Delete option back for Developers
• SHS-5133: Remove redundant aria-hidden_tabindex and add alt on images in links

Need Review By (Date)

11/29

Urgency

medium

Steps to Test

SHS-5130

1. Edit a page
2. Add a new page component, and choose Color Band
3. Do not add text to the text field and save
4. Ensure that if the color band has no text, an <hr> tag prints inside the color band.
5. Ensure that color bands with text still print the same as before.

SHS-5113

1. Visit any page as a "Developer" user. You should see the Editoria11y widget in the bottom right corner
2. Click on the widget. You should see a panel with three tabs. The second tab should have the title "Heading Outline" instead of "Outline"
   
3. Visit a page with an Editoria11y alert status (red outline widget). If you can't find one, you can create a flexible page and add an empty heading in the Text Area. Confirm that the widget error count text is black instead of red.
   

SHS-5119

1.Visit a Layout Builder Page like https://hs-colorful.suhumsci.loc/admin/structure/types/manage/hs_person/display/default/layout
2. Click on a Pencil icon next to one of the blocks, and then click "Configure"
3. Ensure that the modal window appears in front of the grayed-out panel (instead of behind it.)

SHS-5095

1. Visit the user login page, like https://hs-colorful.suhumsci.loc/user/login
2. Ensure that the page is using the custom theme, and not Gin Admin theme.
3. Ensure the there is only one title, the box-shadows have been removed, and the title is black (and not a light gray.)

SHS-5148

1. Visit https://hs-colorful.suhumsci.loc/default-views/people
2. Confirm that the "Research Areas" items present in some cards have a bottom border on hover
3. Repeat test on https://hs-traditional.suhumsci.loc/default-views/people

SHS-5086

1. Visit nodes of different content types as an user with the "Developer" role. You should be able to see and use the "Delete" local task
2. Repeat the test with a couple of other users with different roles. The "Delete" local task shouldn't be present

SHS-5133: Remove redundant aria-hidden_tabindex and add alt on images in links

1. Visit a page with cards that have a linked image in them, like https://english.suhumsci.loc/
2. Ensure that on cards that have linked images, the images no longer have the aria-hidden: true and tab-index: -1 attributes.

PR Checklist

• PR Checklist
• Humsci Basic PR Checklist