SHS-5986: Uninstall Default Paragraphs module #1710
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
callinmullaney
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
@codechefmarc PR looks good on my end and the requested modules have been uninstalled:
|
@ahughes3 This PR is looking good to me. This should cover the second-to-last step in the process of removing these modules from the code base. Ready for you to confirm they are uninstalled. |
sethprime
approved these changes
Jan 9, 2025
pookmish
requested changes
Jan 10, 2025
Comment on lines
+1193
to
+1194
| $config_factory = \Drupal::configFactory(); | ||
| $config_factory->getEditable('paragraphs_browser.paragraphs_browser_type.content')->delete(); |
| /** | ||
| * Uninstall hs_paragraphs_between and paragraphs_browser. | ||
| */ | ||
| function su_humsci_profile_update_9721() { |
There was a problem hiding this comment.
This will conflict with the other PR to uninstall honeypot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Uninstalls
hs_paragraphs_betweenandparagraphs_browseras they have been replaced with functionality from other modules. Composer changes to be removed from codebase in a subsequent codebase after release.Need Review By (Date)
2025-01-08
Urgency
low
Steps to Test
/admin/modulesPR Checklist