Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5944 and SHS-5986 #1713

Merged
merged 10 commits into from
Jan 10, 2025
Merged

Conversation

codechefmarc
Copy link
Collaborator

@codechefmarc codechefmarc commented Jan 10, 2025

Summary

  • Uninstalls hs_paragraphs_between and paragraphs_browser as they have been replaced with functionality from other modules. Composer changes to be removed from codebase in a subsequent codebase after release.
  • Removes configuration for and uninstalls Honeypot module

Need Review By (Date)

2025-01-15

Urgency

low

Steps to Test

  1. Login to the site as a developer
  2. Visit the modules page at /admin/modules
  3. Verify that H&S Paragraphs Between and Paragraph Browser are both uninstalled
  4. Verify that Honeypot module has been uninstalled
  5. Verify that, when adding Flexible and Private pages, there is still an "add-in-between" option for paragraphs and that the functionality still works as expected.

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat January 10, 2025 18:30 Destroyed
@codechefmarc codechefmarc requested a review from pookmish January 10, 2025 18:35
@codechefmarc codechefmarc self-assigned this Jan 10, 2025
@codechefmarc codechefmarc marked this pull request as ready for review January 10, 2025 18:35
@pookmish pookmish enabled auto-merge (squash) January 10, 2025 18:36
@pookmish pookmish merged commit d0eedf6 into 11.6.3-release Jan 10, 2025
17 checks passed
@pookmish pookmish deleted the SHS-5944-SHS-5986--uninstall-modules branch January 10, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants