-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: upgrade to SymbolicUtils w/ fast terms #720
Conversation
Co-authored-by: "Yingbo Ma" <[email protected]>
Is this breaking? @YingboMa take a look at Pumas and make sure it stays fine. |
We'll need some Catalyst updates too. |
Yeah, it's a little breaking, unfortunately. I will test those when this PR and the SymbolicUtils PR are finalized. |
Yeah so this probably qualifies for a breaking release. |
Yeah no worries. I am fine with having it a bit common in this stage in the repo, especially for a 100x performance gain. It just needs to be done right and take care of our downstream buddies |
If we are going to do a breaking release anyway. Let's also sneak in #684 :P |
All tests pass locally for me now. |
@isaacsas @ChrisRackauckas (ping anyone else using this package downstream) This is a breaking change! Let me summarize what this means to ModelingToolkit users:
Here is what changed (and a migration guide) in SymbolicUtils.jl JuliaSymbolics/SymbolicUtils.jl#154 (comment) if you need to get into the finer details. |
Thanks, makes sense. Let's make sure own downstream libraries all get PRs too. |
I’d like to do some more breaking changes before we merge it, like changing
the BipartiteGraph struct and the derivative.
|
Sounds good. |
It's the annoying string LaTeX test again... Can we just delete it to test for nonempty string? Or only looking for some patterns. |
what's going on there? |
Oh, this is actually due to the exp change. I will fix it. |
Fingers crossed. CI should pass in this commit. |
This PR also deprecates
.op
and.args
onTerm
s.Most of the functionalities are upgraded except Hessian sparsity. @shashi is looking into that.