Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: FAILED tests/drivers/test_remote_webdriver.py::test_downloads - EOFError #1568

Closed
rdinoff opened this issue Jan 24, 2024 · 5 comments
Labels
bug Something isn't working needs-triaging

Comments

@rdinoff
Copy link
Contributor

rdinoff commented Jan 24, 2024

What happened?

$ cd seleniumhq.github.io/examples/python/
$ pytest tests/drivers/test_remote_webdriver.py

The code should be updated to use file_names[0] instead of files[0] as files does not get returned in a consistent order which is why the sort is needed in the assert

       assert sorted(files) == sorted(file_names)
       downloadable_file = file_names[0]
[error.txt](https://github.com/SeleniumHQ/seleniumhq.github.io/files/14042672/error.txt)

What browsers and operating systems are you seeing the problem on?

Description: Ubuntu 20.04.6 LTS
Python 3.8.10
selenium-server-4.16.1.jar

@rdinoff rdinoff added bug Something isn't working needs-triaging labels Jan 24, 2024
Copy link
Contributor

@rdinoff, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@titusfortner
Copy link
Member

do you want to PR the fix?

@rdinoff
Copy link
Contributor Author

rdinoff commented Jan 25, 2024

do you want to PR the fix?

yes, I will make a PR

@diemol
Copy link
Member

diemol commented Feb 19, 2024

It seems the PR got merged into your fork.

diemol pushed a commit that referenced this issue Feb 21, 2024
[py] Update test_remote_webdriver.py to use file_names

files does not get returned in a consistent order from get_downloadable_files() which is why the sort is needed in the assert.  Use file_names instead
@diemol
Copy link
Member

diemol commented Apr 25, 2024

This was already fixed.

@diemol diemol closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triaging
Projects
None yet
Development

No branches or pull requests

3 participants