Skip to content

Commit

Permalink
Use launch instead of compose to get image from DockerHub (#85)
Browse files Browse the repository at this point in the history
  • Loading branch information
Dref360 authored Jun 3, 2022
1 parent c6defba commit aabc1ea
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 5 deletions.
26 changes: 26 additions & 0 deletions .github/workflows/docker_cd.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Docker
on:
push:
tags:
- "v*"
jobs:
docker-deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- run: |
make DEVICE=gpu build push
make DEVICE=cpu build push
make TAG=$VERSION DEVICE=gpu build push
make TAG=$VERSION DEVICE=cpu build push
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ in [Learn Basics](https://servicenow.github.io/azimuth/getting-started/b-basics/
```
pip install gdown
make download_demo
make CFG_PATH=/config/development/clinc/conf.json compose
make CFG_PATH=/config/development/clinc/conf.json launch
```

Once the startup tasks are completed, you will be able to access Azimuth at `http://0.0.0.0:8080`.
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/development/launching.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ yarn start
### Launch Using Docker
* Docker compose will build the images and connect them, using the following command.
```
make CFG_PATH=/config/examples/.../conf.json compose
make CFG_PATH=/config/examples/.../conf.json launch
```
_Note that the path starts with `/config` as we mount `./config:/config`._
4 changes: 2 additions & 2 deletions docs/docs/getting-started/b-basics.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ running a demo.
1. If you don't have a lot of time and just want to verify your setup, you can run our dummy
CLINC demo (~2min):
```
make CFG_PATH=/config/development/clinc_dummy/conf.json compose
make CFG_PATH=/config/development/clinc_dummy/conf.json launch
```
2. If you have a bit more time, run our full CLINC demo (~10min):
```
make CFG_PATH=/config/development/clinc/conf.json compose
make CFG_PATH=/config/development/clinc/conf.json launch
```
3. The **app will be accessible** at [http://0.0.0.0:8080](http://0.0.0.0:8080) after a few minutes
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/getting-started/c-run.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ dataset and model are available in `config/examples` (`CLINC` is also shown belo
container at the root.
3. Execute the following **command**:
```
make compose
make launch
```
4. The **app will be accessible** at `http://0.0.0.0:8080` after a few minutes of waiting. The
start-up tasks will start.
Expand Down

0 comments on commit aabc1ea

Please sign in to comment.