Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use launch instead of compose to get image from DockerHub #85

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

Dref360
Copy link
Contributor

@Dref360 Dref360 commented Jun 1, 2022

Description:

Our users can now take images from DockerHub instead of building manually.
This PR tries to automate the process.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.

  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • FRONTEND TYPES. Regenerate the front-ent types if you played with types and routes.
    Run cd webapp && yarn types while the back-end is running.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the image gets updated everytime we merge on main? Do they still need to git clone our repo?

@Dref360
Copy link
Contributor Author

Dref360 commented Jun 1, 2022

Every time we make a new tag.
This is a first step toward providing "releases" where people wont have to clone the repo.

What I see in the future is:

  • We create an "azimuth package" with docker-compose.yml, configs, azimuth_shr, etc.
  • On the documentation website we have instructions to download said package
    • Ex: curl servicenow.github.io/azimuth/get_azimuth.sh | sh

Then our users can quickly get Azimuth running on their usecase.

Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just missing in the README to change from compose to launch!

@Dref360
Copy link
Contributor Author

Dref360 commented Jun 2, 2022

Will merge once all the images are pushed (probably by eod)

@Dref360 Dref360 merged commit aabc1ea into main Jun 3, 2022
@Dref360 Dref360 deleted the hotfix/dockerhub branch June 3, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants