Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use launch instead of compose to get image from DockerHub #85

Merged
merged 2 commits into from
Jun 3, 2022
Merged

Use launch instead of compose to get image from DockerHub #85

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2eeb2a
Use launch instead of compose to get image from DockerHub
Jun 1, 2022
17e5232
Fix in README as well
Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions .github/workflows/docker_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Docker
on:
push:
tags:
- "v*"
jobs:
docker-deploy:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Get the version
id: get_version
run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
- name: Login to Docker Hub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- run: |
make DEVICE=gpu build push
make DEVICE=cpu build push
make TAG=$VERSION DEVICE=gpu build push
make TAG=$VERSION DEVICE=cpu build push
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}

2 changes: 1 addition & 1 deletion docs/docs/development/launching.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,6 @@ yarn start
### Launch Using Docker
* Docker compose will build the images and connect them, using the following command.
```
make CFG_PATH=/config/examples/.../conf.json compose
make CFG_PATH=/config/examples/.../conf.json launch
```
_Note that the path starts with `/config` as we mount `./config:/config`._
4 changes: 2 additions & 2 deletions docs/docs/getting-started/b-basics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ running a demo.
1. If you don't have a lot of time and just want to verify your setup, you can run our dummy
CLINC demo (~2min):
```
make CFG_PATH=/config/development/clinc_dummy/conf.json compose
make CFG_PATH=/config/development/clinc_dummy/conf.json launch
```
2. If you have a bit more time, run our full CLINC demo (~10min):
```
make CFG_PATH=/config/development/clinc/conf.json compose
make CFG_PATH=/config/development/clinc/conf.json launch
```

3. The **app will be accessible** at [http://0.0.0.0:8080](http://0.0.0.0:8080) after a few minutes
Expand Down
2 changes: 1 addition & 1 deletion docs/docs/getting-started/c-run.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ dataset and model are available in `config/examples` (`CLINC` is also shown belo
container at the root.
3. Execute the following **command**:
```
make compose
make launch
```
4. The **app will be accessible** at `http://0.0.0.0:8080` after a few minutes of waiting. The
start-up tasks will start.
Expand Down