Plugin method should accept string variable as argument

[neilime]

Fix error "Internal error: Argument passed to Laminas\View\Renderer\PhpRenderer::plugin should be a string, string given" when ViewModel->plugin is called with a variable containing a string instead of a pure string:

$name = 'form';

// ...

$this->getView()->plugin($name);

[Slamdunk]

Hi, thank you for reporting the issue. Can you add tests to your patch please?

[neilime]

@Slamdunk I have added some tests

[Slamdunk]

Is there a way in this case to get the string raw value?

[ondrejmirtes]

If the type is ConstantStringType then you can ask for $argType->getValue()

[Slamdunk]

@ondrejmirtes we would like to catch here the raw value of $name variable, which is 'url' from few lines above, can we?

[ondrejmirtes]

You can see the literal values only in the same method body, not across method boundaries.

[Slamdunk]

Ok thank you

[Slamdunk]

@neilime why not simply$argType instanceof ConstantStringType ?

[ondrejmirtes]

This is actually better. It accounts for 'foo'|'bar' etc.

[Slamdunk]

Thank you @neilime and @ondrejmirtes