Plugin method should accept string variable as argument

src/Type/Laminas/PluginMethodDynamicReturnTypeExtension/AbstractPluginMethodDynamicReturnTypeExtension.php

@@ -8,10 +8,13 @@
 use PhpParser\Node\Expr\MethodCall;
 use PHPStan\Analyser\Scope;
 use PHPStan\Reflection\MethodReflection;
+use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
 use PHPStan\Type\ObjectType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\TypeUtils;
 use PHPStan\Type\VerbosityLevel;
 
 abstract class AbstractPluginMethodDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
@@ -36,18 +39,25 @@ final public function getTypeFromMethodCall(
         MethodCall $methodCall,
         Scope $scope
     ): Type {
-        $pluginManager = $this->serviceManagerLoader->getServiceLocator($this->getPluginManagerName());
-        $argType       = $scope->getType($methodCall->args[0]->value);
-        if (! $argType instanceof ConstantStringType) {
-            throw new \PHPStan\ShouldNotHappenException(\sprintf('Argument passed to %s::%s should be a string, %s given',
-                $methodReflection->getDeclaringClass()->getName(),
-                $methodReflection->getName(),
-                $argType->describe(VerbosityLevel::typeOnly())
-            ));
+        $argType = $scope->getType($methodCall->args[0]->value);
+        $strings = TypeUtils::getConstantStrings($argType);
+        $plugin = count($strings) === 1 ? $strings[0]->getValue() : null;
+
+        if ($plugin) {
+            $pluginManager = $this->serviceManagerLoader->getServiceLocator($this->getPluginManagerName());
+            return new ObjectType(\get_class($pluginManager->get($plugin)));
         }
-        $pluginClass   = \get_class($pluginManager->get($argType->getValue()));
 
-        return new ObjectType($pluginClass);
+        if ($argType instanceof StringType) {            
+            $defaultReturnType = ParametersAcceptorSelector::selectFromArgs($scope, $methodCall->args, $methodReflection->getVariants())->getReturnType();
+            return $defaultReturnType;
+        }
+
+        throw new \PHPStan\ShouldNotHappenException(\sprintf('Argument passed to %s::%s should be a string, %s given',
+            $methodReflection->getDeclaringClass()->getName(),
+            $methodReflection->getName(),
+            $argType->describe(VerbosityLevel::value())
+        ));
     }
 
     abstract protected function getPluginManagerName(): string;

tests/LaminasIntegration/data/pluginMethodDynamicReturn-2.json

@@ -1,7 +1,12 @@
 [
     {
         "message": "Call to an undefined method Laminas\\View\\Helper\\Url::foobar().",
-        "line": 21,
+        "line": 22,
+        "ignorable": true
+    },
+    {
+        "message": "Call to an undefined method Laminas\\View\\Helper\\AbstractHelper::foobar().",
+        "line": 28,
         "ignorable": true
     }
 ]

tests/LaminasIntegration/data/pluginMethodDynamicReturn.php

@@ -6,6 +6,7 @@
 
 use Laminas\Router\SimpleRouteStack;
 use Laminas\View\Renderer\PhpRenderer;
+use Laminas\View\Helper\AbstractHelper;
 
 final class pluginMethodDynamicReturn
 {
@@ -14,10 +15,22 @@ final class pluginMethodDynamicReturn
      */
     private $phpRenderer;
 
-    public function getDynamicType(): void
+    public function getDynamicTypeFromStaticString(): void
     {
         $urlHelper = $this->phpRenderer->plugin('url');
         $urlHelper->setRouter(new SimpleRouteStack());
         $urlHelper->foobar();
     }
+
+    public function callGetDynamicTypeFromVariable(): void
+    {
+        $urlHelper = $this->getDynamicTypeFromStringVariable('url');
+        $urlHelper->foobar();
+    }
+
+    public function getDynamicTypeFromStringVariable(string $name): AbstractHelper
+    {
+        return $this->phpRenderer->plugin($name);
+    }
+
 }