Add required bindings to the like count container. closes #562 #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vladjerca
commented
Jan 29, 2016
vladjerca
commented
- clicking the count container will now trigger the like song event
- SCSS has been updated in order to set the active color after the song is liked
- clicking the count container will now trigger the like song event - SCSS has been updated in order to set the active color after the song is liked
vladjerca
changed the title
weblancaster
changed the title
| @@ -9,7 +9,9 @@ | |||
| <span class="playback_count"> | |||
| <i class="fa fa-play"></i> {{track.playback_count | number}} | |||
| </span> | |||
| <span class="likes_count"> | |||
| <span class="likes_count" ng-click="changeLike()" | |||
There was a problem hiding this comment.
why do we have ng-click="changeLike()" but isn't being used.
|
@vladjerca the heart state changes but theres a couple of things I noticed.. the number/counter doesn't change.. also there is a piece of code not in use Can you make the counter go up as well? |
|
@weblancaster Yeah, I can take care of it. |
|
@vladjerca let me know once you are done with this. |
- add count definition to favoriteSong directive and update accordingly after each event - removed remnant changeLike from click events
|
@weblancaster I've updated the directive definition and modified all affected html sections. |
|
Thanks for the PR @vladjerca and apologies for the delay in review. |
weblancaster
added a commit
that referenced
this pull request
Feb 19, 2016
Add required bindings to the like count container. closes #562
|
I love the app, only seems logical to give back how much I can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.