fix: (Cloud)AppAdmin informations gathering #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @sklaer. Thank you very much for this PR. We are getting ready to release a complete ground-up rewrite of AzureHound, which will completely deprecate the PowerShell version of AzureHound. I'm going to merge your PR here because I want to make sure you get credit for this, but the entirety of the PowerShell version of AzureHound is going to be deprecated very soon. |
andyrobbins
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AzureHound data collection for application and cloud application administrators which was always empty.
The fix includes changing several attributes, a variable used incorrectly ($AppAdmins instead of $CloudAppAdmins) as well as filters used to retrieve service principals.