Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Cloud)AppAdmin informations gathering #547

Merged
merged 1 commit into from
Jul 27, 2022
Merged

fix: (Cloud)AppAdmin informations gathering #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions Collectors/AzureHound.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,7 @@ function Invoke-AzureHound {
Write-Info "Processing Privileged Role Admin role"
$PrivRoleColl = New-Object System.Collections.ArrayList
$PrivilegedRoleAdmins = $UserRoles | ? { $_.RoleID -Contains 'e8611ab8-c189-46e8-94e1-60213ab1f814' }
$PrivilegedRoleAdminRights = ForEach ($User in $PrivilegedRoleAdmins) {
ForEach ($User in $PrivilegedRoleAdmins) {

$PrivilegedRoleAdminRight = [PSCustomObject]@{
UserName = $User.UserName
Expand Down Expand Up @@ -1359,12 +1359,12 @@ function Invoke-AzureHound {
$SPOS = Get-AzADApplication | Get-AzADServicePrincipal | %{

$ServicePrincipals = [PSCustomObject]@{
AppId = $_.ApplicationId
AppId = $_.AppId
AppName = $_.DisplayName
ServicePrincipalId = $_.Id
ServicePrincipalType = $_.ObjectType
ServicePrincipalType = $_.ServicePrincipalType
}

$ServicePrincipals
$null = $Coll.Add($ServicePrincipals)

}
Expand Down Expand Up @@ -1393,20 +1393,20 @@ function Invoke-AzureHound {
# Application Admins - Can create new secrets for application service principals
# Write to appadmins.json
$AppAdmins = $UserRoles | Where-Object {$_.RoleID -match '9b895d92-2cd3-44c7-9d02-a6ac2d5ea5c3'}
$SPsWithAzureAppAdminRole = $UserRoles | Where-Object {$_.RoleID -match '9b895d92-2cd3-44c7-9d02-a6ac2d5ea5c3' -and $_.UserType -match 'serviceprincipal' }
$SPsWithAzureAppAdminRole = $UserRoles | Where-Object {$_.ObjectType -match 'serviceprincipal' }
$AppsWithAppAdminRole = ForEach ($SP in $SPsWithAzureAppAdminRole) {
$AppWithRole = $SPOS | ?{$_.ServicePrincipalID -Match $SP.UserID}
$AppWithRole = $SPOS | Where-Object {$_.ServicePrincipalID -Match $SP.UserID}
$AppWithRole
}
$AppAdminsRights = ForEach ($Principal in $AppAdmins) {
ForEach ($Principal in $AppAdmins) {

$TargetApps = $AppsWithAppAdminRole

ForEach ($TargetApp in $TargetApps) {

$AppRight = [PSCustomObject]@{
AppAdminID = $Principal.UserID
AppAdminType = $Principal.UserType
AppAdminType = $Principal.ObjectType
AppAdminOnPremID = $Principal.UserOnPremID
TargetAppID = $TargetApp.AppID
}
Expand All @@ -1419,7 +1419,7 @@ function Invoke-AzureHound {

$AppRight = [PSCustomObject]@{
AppAdminID = $Principal.UserID
AppAdminType = $Principal.UserType
AppAdminType = $Principal.ObjectType
AppAdminOnPremID = $Principal.UserOnPremID
TargetAppID = $TargetApp.AppID
}
Expand All @@ -1436,20 +1436,20 @@ function Invoke-AzureHound {
Write-Info "Processing Cloud Application Admins"
$Coll = New-Object System.Collections.ArrayList
$CloudAppAdmins = $UserRoles | Where-Object {$_.RoleID -match '158c047a-c907-4556-b7ef-446551a6b5f7'}
$SPsWithAzureAppAdminRole = $UserRoles | Where-Object {$_.RoleID -match '158c047a-c907-4556-b7ef-446551a6b5f7' -and $_.UserType -match 'serviceprincipal' }
$SPsWithAzureAppAdminRole = $UserRoles | Where-Object {$_.ObjectType -match 'serviceprincipal'}
$AppsWithAppAdminRole = ForEach ($SP in $SPsWithAzureAppAdminRole) {
$AppWithRole = $SPOS | ?{$_.ServicePrincipalID -Match $SP.UserID}
$AppWithRole = $SPOS | Where-Object {$_.ServicePrincipalID -Match $SP.UserID}
$AppWithRole
}
$CloudAppAdminRights = ForEach ($Principal in $AppAdmins) {
ForEach ($Principal in $CloudAppAdmins) {

$TargetApps = $AppsWithAppAdminRole

ForEach ($TargetApp in $TargetApps) {

$AppRight = [PSCustomObject]@{
AppAdminID = $Principal.UserID
AppAdminType = $Principal.UserType
AppAdminType = $Principal.ObjectType
AppAdminOnPremID = $Principal.UserOnPremID
TargetAppID = $TargetApp.AppID
}
Expand All @@ -1462,7 +1462,7 @@ function Invoke-AzureHound {

$AppRight = [PSCustomObject]@{
AppAdminID = $Principal.UserID
AppAdminType = $Principal.UserType
AppAdminType = $Principal.ObjectType
AppAdminOnPremID = $Principal.UserOnPremID
TargetAppID = $TargetApp.AppID
}
Expand Down