-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] limit persistent index compaction by disk (backport #36681) #37693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why I'm doing: In current implementation, we doesn't control the compaction concurrency on one disk, which will cause compaction unbalanced between disks, and some disk's IO cost will be too high. What I'm doing: Limit the disk compaction concurrency by config pindex_major_compaction_limit_per_disk . Refactor persistent index compaction scheduler code. Signed-off-by: luohaha <[email protected]> (cherry picked from commit a44147f) # Conflicts: # be/src/storage/persistent_index.h # be/src/storage/persistent_index_compaction_manager.cpp
22 tasks
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Signed-off-by: Yixin Luo <[email protected]>
Signed-off-by: Yixin Luo <[email protected]>
luohaha
previously approved these changes
Dec 25, 2023
Signed-off-by: Yixin Luo <[email protected]>
luohaha
approved these changes
Dec 25, 2023
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 1 / 27 (03.70%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #36681 done by Mergify.
Cherry-pick of a44147f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com
What I'm doing:
pindex_major_compaction_limit_per_disk
.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: