Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37711

Merged
merged 1 commit into from
Dec 25, 2023
Merged

[Enhancement] add switch enable_materialized_view_rewrite_for_insert (backport #37505) #37711

merged 1 commit into from
Dec 25, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 25, 2023 •
edited by murphyatwork
Loading

This is an automatic backport of pull request #37505 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Why I'm doing: - MV rewrite for insert statement is trivial and dangerous, considering that the InsertPlanner would take the DbLock, and in corner case the rewrite procedure would take a long time - So consider disable it by default

What I'm doing:

  • Add a switch enable_materialized_view_rewrite_for_insert to enable rewrite for insert statement
  • Default value is false

Behavior change:

  • Before: MV rewrite for insert statement is enabled
  • After: MV rewrite for insert statement is disabled

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Dec 25, 2023
@mergify mergify bot mentioned this pull request Dec 25, 2023
Merged
23 tasks
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 25, 2023 07:02
@mergify mergify bot closed this Dec 25, 2023
auto-merge was automatically disabled December 25, 2023 07:02

Pull request was closed

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Dec 25, 2023

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-37505 branch December 25, 2023 07:02
@murphyatwork murphyatwork restored the mergify/bp/branch-2.5/pr-37505 branch December 25, 2023 10:32
@murphyatwork murphyatwork reopened this Dec 25, 2023
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) December 25, 2023 10:33
@murphyatwork
[Enhancement] add switch enable_materialized_view_rewrite_for_insert (#…
ce73991 
…37505)

Signed-off-by: Murphy <[email protected]>
(cherry picked from commit 1996cb1)
Signed-off-by: Murphy <[email protected]>

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
#	fe/fe-core/src/main/java/com/starrocks/sql/InsertPlanner.java
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MvRewriteTest.java
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 25, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 12 / 14 (85.71%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/qe/SessionVariable.java 5 7 71.43% [2233, 2234]
🔵 com/starrocks/qe/VariableMgr.java 1 1 100.00% []
🔵 com/starrocks/sql/InsertPlanner.java 6 6 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wanpengfei-git wanpengfei-git merged commit 2838952 into branch-2.5 Dec 25, 2023
27 of 28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-37505 branch December 25, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murphyatwork murphyatwork murphyatwork approved these changes

Assignees

@murphyatwork murphyatwork

Labels
automerge behavior_changed conflicts version:2.5.18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murphyatwork @wanpengfei-git