[BugFix] Fix delete LOCATION_MISMATCH redundant replica bug #50331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gengjun-git
changed the title
nshangyiming
approved these changes
Aug 27, 2024
|
@Mergifyio rebase |
Signed-off-by: gengjun-git <[email protected]>
Signed-off-by: gengjun-git <[email protected]>
✅ Branch has been successfully rebased |
gengjun-git
force-pushed
the
fix_location_mismatch_bug
branch
from
f0b5419
to
d38e422
Compare
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 7 / 11 (63.64%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
HangyuanLiu
approved these changes
Aug 29, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit 4845e33)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
Signed-off-by: gengjun-git <[email protected]> (cherry picked from commit 4845e33)
42 tasks
wanpengfei-git
pushed a commit
that referenced
this pull request
Aug 29, 2024
…50331) (#50415) Co-authored-by: gengjun-git <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 6, 2024
…50331) (#50414) Co-authored-by: gengjun-git <[email protected]>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
Sep 6, 2024
…tarRocks#50331) (StarRocks#50414) Co-authored-by: gengjun-git <[email protected]>
va-os-commits
pushed a commit
to va-os-commits/starrocks
that referenced
this pull request
Sep 10, 2024
…s#50331) Signed-off-by: gengjun-git <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…s#50331) Signed-off-by: gengjun-git <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
There are 6 backends with location tags:
be1 rack:rack1
be2 rack:rack1
be3 rack:rack2
be4 rack:rack2
be5 rack:rack3
be6 rack:rack3
And a table with
"labels.location" = "rack:rack1,rack:rack2,rack:rack3"If a tablet's 3 replicas is stored on be1, be2, be3. one replica should be migrated to be5/be6 from be1/be2. But the redundant replica deleted is not be1/be2, causing clone/delete Repeated execution.
What I'm doing:
The duplicate location replica should be deleted in
deleteLocationMismatchReplica.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: