[BugFix] Fix delete LOCATION_MISMATCH redundant replica bug (StarRock…

…s#50331) Signed-off-by: gengjun-git <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
renzhimin7 · Nov 7, 2024 · 8dca4d6 · 8dca4d6
1 parent e476ce8
commit 8dca4d6
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/fe/fe-core/src/main/java/com/starrocks/clone/TabletScheduler.java b/fe/fe-core/src/main/java/com/starrocks/clone/TabletScheduler.java
@@ -94,6 +94,7 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Map;
 import java.util.Objects;
@@ -1151,13 +1152,33 @@ private boolean deleteLocationMismatchReplica(TabletSchedCtx tabletCtx, boolean
             // won't delete location mismatched replica.
             return false;
         }
+
+        Set<Pair<String, String>> matchedLocations = new HashSet<>();
+        Replica dupReplica = null;
+        //1. delete the unmatched replica
         for (Replica replica : tabletCtx.getReplicas()) {
             if (!TabletChecker.isLocationMatch(replica.getBackendId(), tabletCtx.getRequiredLocation())) {
                 deleteReplicaInternal(tabletCtx, replica, "location mismatch", force);
                 return true;
+            } else {
+                Backend backend = systemInfoService.getBackend(replica.getBackendId());
+                if (backend != null) {
+                    Pair<String, String> location = backend.getSingleLevelLocationKV();
+                    if (location != null && matchedLocations.contains(location)) {
+                        dupReplica = replica;
+                    } else {
+                        matchedLocations.add(location);
+                    }
+                }
             }
         }
 
+        //2. delete the duplicate location replica
+        if (dupReplica != null) {
+            deleteReplicaInternal(tabletCtx, dupReplica, "duplicate location", force);
+            return true;
+        }
+
         return false;
     }