-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Make cpu_weight always store positive default value #51005
Merged
satanson
merged 2 commits into
StarRocks:main
from
ZiheLiu:fix/main/resource_group_down
Sep 18, 2024
Merged
[BugFix] Make cpu_weight always store positive default value #51005
satanson
merged 2 commits into
StarRocks:main
from
ZiheLiu:fix/main/resource_group_down
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zihe.liu <[email protected]>
24 tasks
Signed-off-by: zihe.liu <[email protected]>
Quality Gate passedIssues Measures |
kangkaisen
approved these changes
Sep 13, 2024
satanson
approved these changes
Sep 13, 2024
kangkaisen
pushed a commit
that referenced
this pull request
Sep 13, 2024
…#51005) (#51008) Signed-off-by: zihe.liu <[email protected]>
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 13 / 13 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
HangyuanLiu
approved these changes
Sep 18, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…ks#51005) Signed-off-by: zihe.liu <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Recently, a change was made allowing the resource parameter
cpu_weight
, which previously had to be positive, to now be non-positive.After downgrading from current version, since the old version of BE expects
cpu_weight
to be positive (e.g., using it as a divisor), this could lead to crashes or unexpected behavior.What I'm doing:
To address this, ensure that when a resource group is persisted, the stored value is always a positive integer.
Additionally, when using the value, the
getNormalizedCpuWeight()
method will ensure thatcpu_weight
returns 0 whenexclusive_cpu_cores
is positive.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: