[BugFix] Make cpu_weight always store positive default value (backport #51005) #51008
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP from #51005.
Why I'm doing:
Recently, a change was made allowing the resource parameter
cpu_weight
, which previously had to be positive, to now be non-positive.After downgrading from current version, since the old version of BE expects
cpu_weight
to be positive (e.g., using it as a divisor), this could lead to crashes or unexpected behavior.What I'm doing:
To address this, ensure that when a resource group is persisted, the stored value is always a positive integer.
Additionally, when using the value, the
getNormalizedCpuWeight()
method will ensure thatcpu_weight
returns 0 whenexclusive_cpu_cores
is positive.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: