Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LoadNextPage for LibraryWithFilters #643

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Feb 27, 2024

Update the pagination logic to just append more items with LoadNextPage instead of returning slices
Related Stremio/stremio-core-web#99

@tymmesyde tymmesyde force-pushed the refactor/library-with-filters-load-next-page branch 2 times, most recently from f84daa4 to 8ade441 Compare February 27, 2024 09:20
@tymmesyde tymmesyde force-pushed the refactor/library-with-filters-load-next-page branch from 8ade441 to 9cc62ac Compare February 27, 2024 09:26
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with CATALOG_PAGE_SIZE of 14 and works using the other 2 PRs in web and core-web.

@elpiel elpiel merged commit 895d418 into development Feb 29, 2024
2 checks passed
@elpiel elpiel deleted the refactor/library-with-filters-load-next-page branch February 29, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants