Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library infinite scroll #595

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

tymmesyde
Copy link
Member

elpiel
elpiel previously approved these changes Feb 29, 2024
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested changes and the infinite scroll seems to be working.
Needs more testing to validate how well it's working as I had one or two instances where I've scrolled to the bottom very quickly with my touchpad and it didn't trigger the next set of LibraryItems

@kKaskak kKaskak self-requested a review March 8, 2024 21:48
src/routes/Library/Library.js Outdated Show resolved Hide resolved
@tymmesyde tymmesyde marked this pull request as ready for review March 13, 2024 17:14
@tymmesyde tymmesyde requested a review from kKaskak March 13, 2024 17:14
@tymmesyde tymmesyde requested a review from TRtomasz March 13, 2024 17:16
@tymmesyde tymmesyde merged commit d623801 into development Mar 13, 2024
2 checks passed
@elpiel elpiel deleted the refactor/library-infinite-scroll branch July 29, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants