Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity between Html and SelectableHtml #717

Closed
jhass opened this issue Jun 1, 2021 · 9 comments · Fixed by #1176
Closed

Feature parity between Html and SelectableHtml #717

jhass opened this issue Jun 1, 2021 · 9 comments · Fixed by #1176
Labels
enhancement New feature or request selectable-html
Milestone

Comments

@jhass
Copy link

jhass commented Jun 1, 2021

#169 got closed through #682 introducing a SelectableHtml with a feature subset currently achievable with Flutter's support level. Reaching feature parity is blocked by flutter/flutter#38474, but once this is resolved it would be nice to have a full implementation.

@jhass jhass added the enhancement New feature or request label Jun 1, 2021
@tneotia
Copy link
Collaborator

tneotia commented Jun 1, 2021

Yep, that is the plan once the Flutter issue is closed. #632 adds customRender back for SelectableHtml.

@tneotia
Copy link
Collaborator

tneotia commented Jul 23, 2021

Alright, the Flutter PR adding support for widget span in editable text has been merged. We can't use it quite yet in the SelectableText (it's just a matter of removing an assert from the framework) but hopefully this should be coming soon and I will experiment with it. Currently they are working on how they want to do clipboard support.

@erickok
Copy link
Collaborator

erickok commented Jan 18, 2022

We merged custtomRender support for SelectableHtml already into master and you can test it using flutter_html 3.0.0-alpha.2. There is no out-of-the-box feature parity though (notably images are not yet supported).

@dan1229
Copy link

dan1229 commented Jan 18, 2022

So this version doesn’t yet support images? Is that due to a flutter level bug still or something else?

@tneotia
Copy link
Collaborator

tneotia commented Jan 18, 2022

Correct, I experimented with the widget span support inside of selectable html, but there are quite a few issues with it that currently are still game-breaking. We could potentially support very simple use cases like images, videos, or audio, but any sort of container based formatting will still not be supported.

@Sub6Resources
Copy link
Owner

@erickok, I believe this is resolved in the latest flutter version, as flutter/flutter#38474 is now closed. Is that correct?

@tneotia
Copy link
Collaborator

tneotia commented Jun 10, 2022

We would need to explicitly add support for this in the package though. I experimented with it a few months back and it completely breaks text copy paste, so as I said in the previous comment container-based formatting should still not be supported.

@erickok
Copy link
Collaborator

erickok commented Jun 10, 2022

Yes we can give it another go. Perhaps with Flutter 3 it is mature enough.

@vanlooverenkoen
Copy link
Contributor

Any progress on this? Now that flutter has fixed the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request selectable-html
Projects
None yet
6 participants