-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking: Remove SelectableHtml #1153
Conversation
@erickok have you had a chance to look at this PR? |
To be honest, since we're still trying to get a 3.0 ready, breaking the API big time, I'd get rid of the limited SelectableHtml entirely. Deprecations are nice in minor releases and are developer friendly, but we have a clean, superior and 'free' alternative. |
That works for me! I'll get this updated sometime today |
Codecov ReportBase: 51.40% // Head: 51.07% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1153 +/- ##
==========================================
- Coverage 51.40% 51.07% -0.33%
==========================================
Files 19 19
Lines 2640 2561 -79
==========================================
- Hits 1357 1308 -49
+ Misses 1283 1253 -30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@erickok. It's all removed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a README update is needed.
@@ -148,19 +148,11 @@ If you would like to modify or sanitize the HTML before rendering it, then `Html | |||
|
|||
#### Selectable Text | |||
|
|||
The package also has two constructors for selectable text support - `SelectableHtml()` and `SelectableHtml.fromDom()`. | |||
Note: These constructors are deprecated. It is preferred that you use Flutter's new `SelectionArea` instead (just wrap the `Html` widget in a `SelectionArea`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be updated now to reflect it's removal rather than deprecation.
As I've been (finally) working at the migration from |
This should resolve a few issues regarding the
SelectableHtml
/Html
feature parity. Users can achieve a much cleaner result by using aSelectionArea
widget to wrapHtml
.Fixes #1137
Closes #717 Closes #1134 Closes #1105