-
-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CustomRender
to HtmlExtension
#1176
Conversation
CustomRender
to Extension
CustomRender
to Extension
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1176 +/- ##
==========================================
+ Coverage 51.40% 57.16% +5.76%
==========================================
Files 19 36 +17
Lines 2640 2610 -30
==========================================
+ Hits 1357 1492 +135
+ Misses 1283 1118 -165
☔ View full report in Codecov by Sentry. |
Hi @Sub6Resources - is there anything the community can do to help get this PR finished and a new major version released? |
Continuing from #1153 |
CustomRender
to Extension
CustomRender
to Extension
Migrating to Here's a summary of major changes in this PR so far (this list is a work in progress):
|
a218d77
to
cb94fb7
Compare
5ae5cc4
to
76c61ae
Compare
This pull request is ready. Just needs some additional documentation on the Wiki. Anybody that's just stopping in, please review! I'd love to get this release out sometime tomorrow! |
There was a comment made on the initial extension api RFC issue about the name of the api, with re: #1142 (comment) |
@PritamSangani Thanks for pointing that out. I had forgotten about that comment (although I had named all the extension packages as if I had already made the change -- I agree! Just updated from |
CustomRender
to Extension
CustomRender
to HtmlExtension
congrats 🥳 |
Closes #1142
Getting started on this. Here's a task list for myself. Any additional feedback/suggestions are still welcome.
HtmlExtension
classExtensionContext
classHtmlExtension
into theHtml
widget flowTagExtension
helper classMatcherExtension
helper classHtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
HtmlExtension
ImageExtension
classHtmlExtension
Fixes #1137
Closes #717 Closes #1134 Closes #1105
Fixes #1206. Fixes #1199. Fixes #1180. Fixes #1113