Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tests for SVG and fixing height/width bug #1202

Merged
merged 1 commit into from
May 9, 2023
Merged

Adding tests for SVG and fixing height/width bug #1202

merged 1 commit into from
May 9, 2023

Conversation

jlyonsmith
Copy link
Contributor

  • Reduced code by putting attributes in a local
  • Add { } around if's to make code friendlier to code coverage
  • Add more unit tests to get to 57.4%
  • Fix height/width bug in svgTagRender (using width for height)
  • Add height/width to the svgDataImagerRender for Picture.string
  • Refactored unit tests to simplify and reduce code
  • Add coverage and scratch directories to .gitignore

@jlyonsmith
Copy link
Contributor Author

Is there nobody out there to approve this merge?

Sub6Resources
Sub6Resources requested changes May 9, 2023
View reviewed changes
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. (See #1247) These changes are great. Unfortunately, #1176 is going to overwrite a lot of them as we migrate from customRender to extension. I'll consider merging in some of the tests you've written after that PR gets merged.

packages/flutter_html_svg/.gitignore Outdated Show resolved Hide resolved
@jlyonsmith
Adding tests for SVG and fixing height/width bug
e3ec8c5 
- Reduced code by putting attributes in a local
- Add { } around if's to make code friendlier to code coverage
- Add more unit tests to get to 57.4%
- Fix height/width bug in svgTagRender (using width for height)
- Add height/width to the svgDataImagerRender for Picture.string
- Refactored unit tests to simplify and reduce code
- Add coverage and scratch directories to .gitignore
@jlyonsmith
Copy link
Contributor Author

scratch/ directory removed

Sub6Resources
Sub6Resources approved these changes May 9, 2023
View reviewed changes
Copy link
Owner

@Sub6Resources Sub6Resources left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Sub6Resources
Copy link
Owner

I'm gonna merge this now actually and resolve conflicts in #1176

@Sub6Resources Sub6Resources merged commit 9a3d8a3 into Sub6Resources:master May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sub6Resources Sub6Resources Sub6Resources approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlyonsmith @Sub6Resources