feat(metrics): make deleting metrics source metadata optional #3072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is no way to set the source category for metrics, as we are stripping the
_sourceCategory
attribute. This happens after theextraProcessors
are added, so there is no way to override this behavior. This is pretty important for us, as we need to disambiguate metrics from different environments.The comment for this
delete_source_metadata
processor says it's because we need to wait until we can send these attributes as headers, but the sumologic exporter has been doing this since Oct 2022. In tests on our infra with this processor removed, this has been working fine.I added a configuration parameter defaulting to
true
to preserve the old behavior by default, to avoid any unexpected surprises with a sudden cardinality increase.Checklist