Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): make deleting metrics source metadata optional #3072

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(metrics): make deleting metrics source metadata optional #3072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7535536
Make deleting metrics source metadata optional
ryan-codaio May 30, 2023
171b1d6
changelog
ryan-codaio May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/3072.added.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
configuration to make deleting metrics source metadata optional
1 change: 1 addition & 0 deletions deploy/helm/sumologic/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ The following table lists the configurable parameters of the Sumo Logic chart an
| `sumologic.logs.metadata.provider` | Defines logs metadata enrichment provider - `otelcol` or `fluentd`. `otelcol` is the default and is recommended. `fluentd` is deprecated. | `otelcol` |
| `sumologic.metrics.enabled` | Set the enabled flag to false for disabling metrics ingestion altogether. | `true` |
| `sumologic.metrics.metadata.provider` | Defines metrics metadata enrichment provider - `otelcol` or `fluentd`. `otelcol` is the default and is recommended. `fluentd` is deprecated. | `otelcol` |
| `sumologic.metrics.otelcol.deleteSourceMetadata` | Drop the `_sourceCategory`, `_sourceHost`, and `_sourceName` attributes from metrics; may be desired to reduce cardinality. | `true` |
| `sumologic.metrics.otelcol.extraProcessors` | Extra processors configuration for metrics pipeline. See [/docs/collecting-application-metrics.md#metrics-modifications](/docs/collecting-application-metrics.md#metrics-modifications) for more information. | `[]` |
| `sumologic.metrics.remoteWriteProxy.enabled` | Enable a load balancing proxy for Prometheus remote writes. [See docs/best-practices.md for more information.](/docs/best-practices.md) | `true` |
| `sumologic.metrics.remoteWriteProxy.config.clientBodyBufferSize` | See the [nginx documentation](http://nginx.org/en/docs/http/ngx_http_core_module.html#client_body_buffer_size). Increase if you've also increased samples per send in Prometheus remote write. | `64k` |
Expand Down
2 changes: 2 additions & 0 deletions deploy/helm/sumologic/conf/metrics/otelcol/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ processors:
{{- end }}
{{- end }}
- resource/remove_k8s_pod_pod_name
{{- if .Values.sumologic.metrics.otelcol.deleteSourceMetadata }}
- resource/delete_source_metadata
{{- end }}
- sumologic_schema
- batch
- routing
Expand Down
2 changes: 2 additions & 0 deletions deploy/helm/sumologic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,8 @@ sumologic:
cpu: 500m

otelcol:
## Drop the _sourceCategory, _sourceHost, and _sourceName attributes from metrics; may be desired to reduce cardinality.
deleteSourceMetadata: true
## Includes additional processors into pipelines.
## It can be used for filtering metrics, renaming, changing metadata and so on.
## This is list of objects, for example:
Expand Down