Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade OpenTelemetry Core to v0.55.0 #655

Merged
merged 7 commits into from
Jul 13, 2022
Merged

Conversation

sumo-drosiek
Copy link
Contributor

@sumo-drosiek sumo-drosiek commented Jul 7, 2022

upgrade OpenTelemetry Core to v0.55.0 as well as dependencies

@sumo-drosiek sumo-drosiek requested a review from a team as a code owner July 7, 2022 07:34
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 7, 2022
@sumo-drosiek
Copy link
Contributor Author

Please focus on markdown files

@sumo-drosiek sumo-drosiek force-pushed the drosiek-v0.55 branch 2 times, most recently from f5b9cb2 to 0b9572d Compare July 7, 2022 11:14
Copy link

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to use our filterprocessor fork?

@sumo-drosiek
Copy link
Contributor Author

depends how we understand deprecation 😅
I can change it to breaking change and that way we can remove it immediately :)

@swiatekm
Copy link

swiatekm commented Jul 7, 2022

depends how we understand deprecation 😅 I can change it to breaking change and that way we can remove it immediately :)

Do we actually print a deprecation message if someone tries to use it? If not, then I'd just do a breaking change and be done with it.

docs/Upgrading.md Outdated Show resolved Hide resolved
@swiatekm swiatekm self-requested a review July 12, 2022 09:01
@sumo-drosiek
Copy link
Contributor Author

sumo-drosiek commented Jul 13, 2022

I added deprecation message to the filterprocessor:

2022/07/13 08:26:12 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/07/13 08:26:12 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
2022-07-13T08:26:12.060+0200    info    service/telemetry.go:103        Setting up own telemetry...
2022-07-13T08:26:12.060+0200    info    service/telemetry.go:138        Serving Prometheus metrics      {"address": ":8888", "level": "basic"}
2022-07-13T08:26:12.061+0200    info    pipelines/pipelines.go:341      Component is under development. {"kind": "exporter", "data_type": "logs", "name": "logging", "stability": "in development"}
2022-07-13T08:26:12.061+0200    warn    [email protected]/filter_processor_logs.go:221
*********************************************************************************************************************************************************
***    Support for "expr" language is deprecated and is going to be dropped soon. Please see the migration document:                                  ***
***    https://github.com/SumoLogic/sumologic-otel-collector/blob/v0.55.0-sumo-0/docs/Upgrading.md#filter-processor-drop-support-for-expr-language.   ***
*********************************************************************************************************************************************************

#663

CHANGELOG.md Outdated Show resolved Hide resolved
@swiatekm swiatekm self-requested a review July 13, 2022 07:58
@sumo-drosiek sumo-drosiek merged commit b8b6de5 into main Jul 13, 2022
@sumo-drosiek sumo-drosiek deleted the drosiek-v0.55 branch July 13, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants