feat(filterprocessor): drop custom changes #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Custom changes in the filter processor have been deprecated in v0.55.0-sumo-0. This commit drops them.
aboguszewski-sumo
force-pushed
the
drop-filter
branch
from
1c2b625 to
b489eed
Compare
There's nothing to really revert at the moment. What we should do is drop the changes while rebasing on 0.58.0, but I'm not actually sure if there is much to drop, as the changes are in a shared library. We can probably drop them once we're good with the other processors as well. |
swiatekm
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #663
Custom changes in the filter processor have been deprecated in v0.55.0-sumo-0.
According to the discussion under #655, the goal was to stop using any custom changes of the
filterprocessor. However, I was not sure what is the status of the contrib. It seems that theattributesprocessor also uses some related changes. I decided not to drop them.Should we also revert the changes in our contrib fork or not?