fix(sumologicexporter): translate Telegraf metrics with OTLP format #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
reviewed
Jul 7, 2022
This change fixes a regression introduced in #536 that caused the metric name translations (the feature under the `translate_telegraf_attributes` setting) to not work when using the OTLP format. This change refactors the code so that all modifications to metrics (attribute translation, metrics translation, dropping routing attribute) are done before branching the code into different sending formats.
andrzej-stencel
force-pushed
the
translate-metrics-otlp
branch
from
0b698bf to
1ff2e9e
Compare
github-actions
bot
added
the
documentation
sumo-drosiek
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression introduced in #536 that caused the metric name translations (the feature under the
translate_telegraf_attributessetting) to not work when using the OTLP format.This change refactors the code so that all modifications to metrics (attribute translation, metrics translation, dropping routing attribute) are done before branching the code into different sending formats.