feat(sumologicexporter): deprecate setting source headers #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
mat-rumian
reviewed
Aug 1, 2022
| const sourceTemplatesDeprecationBanner = ` | ||
| *********************************************************************************************************************************************************** | ||
| *** Adding source headers is deprecated and is going to be dropped soon. Please see the migration document: *** | ||
| *** https://github.com/SumoLogic/sumologic-otel-collector/blob/main/docs/Upgrading.md#sumologic-exporter-drop-support-for-source-headers. *** |
There was a problem hiding this comment.
I guess that VS Code tricks me, it looks fine in the IDE 😦
mat-rumian
approved these changes
Aug 1, 2022
aboguszewski-sumo
force-pushed
the
sumoexporter-deprecate-source
branch
from
815d99d to
2d0d56e
Compare
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #255 (this PR does not resolve this yet, since it needs to be removed)
The feature of setting the source headers (and source templates) is now deprecated and is going to be removed in v0.60.0.