-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sumologicexporter): remove setting source headers #686
feat(sumologicexporter): remove setting source headers #686
Conversation
5e20734
to
6200011
Compare
6200011
to
b028e81
Compare
b028e81
to
ebfcd72
Compare
if cfg.SourceCategory != "" || cfg.SourceHost != "" || cfg.SourceName != "" { | ||
return fmt.Errorf(`*Deprecation warning*: setting source headers is not supported anymore. | ||
Please consult the changelog at https://github.com/SumoLogic/sumologic-otel-collector/releases/tag/v0.60.0-sumo-0`, | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we really need it. I found some time ago that such warnings have been printed so I added it.
It was also added for attribute translation and telegraf metrics translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We added that because it was deprecated, now it's going to be removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first such warning was this:
sumologic-otel-collector/pkg/exporter/sumologicexporter/config.go
Lines 128 to 134 in 19c766e
if len(cfg.MetadataAttributes) > 0 { | |
return fmt.Errorf(`*Deprecation warning*: metadata_attributes is not supported anymore. | |
Please consult the changelog at https://github.com/SumoLogic/sumologic-otel-collector/releases/tag/v0.49.0-sumo-0`, | |
) | |
} | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ok, but it probably shouldn't say deprecation warning
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumo-drosiek @swiatekm-sumo what's the conclusion then? I'm not against any of the options, but if we don't want it here, we should probably also remove these warnings for other deleted options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd leave the error message, just without calling it a deprecation. WDYT @sumo-drosiek ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@swiatekm-sumo we can do that
56f91af
to
9f4c3a7
Compare
9f4c3a7
to
c100e4a
Compare
c100e4a
to
4189d4a
Compare
Resolves #255
Ref: #685
This PR removes the functionality of setting source headers in the
sumologic
exporter, which has been deprecated some time ago.