Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation via breadcrumbs between credit memo - Order and refund page - order #172

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Navigation via breadcrumbs between credit memo - Order and refund page - order #172

merged 2 commits into from
Jan 14, 2020

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Jan 10, 2020 •
edited
Loading

based on #171
I added breadcrumbs to Credit Memo, fixed breadcrumbs on refunds page, and I deleted redundant route with service from Credit memo index page

refund page:
Screenshot 2020-01-13 at 15 54 01

credit memo page:
Screenshot 2020-01-13 at 15 54 26

@AdamKasp AdamKasp requested a review from a team as a code owner January 10, 2020 14:42
@AdamKasp AdamKasp force-pushed the navigation-CM-refund-order branch from feede8a to 67b99b6 Compare January 10, 2020 14:44
@AdamKasp AdamKasp mentioned this pull request Jan 13, 2020
Closed
@AdamKasp AdamKasp changed the title Navigation cm refund order [WIP] Navigation cm refund order Jan 13, 2020
@AdamKasp AdamKasp changed the title [WIP] Navigation cm refund order [WIP] Navigation cm-refund-order Jan 13, 2020
GSadee
GSadee reviewed Jan 13, 2020
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some screenshots?

PS. this title is a bit magical IMO 💃

spec/Entity/CreditMemoSpec.php Outdated Show resolved Hide resolved
tests/Behat/Context/Transform/OrderContext.php Show resolved Hide resolved
tests/Behat/Resources/suites.yml Outdated Show resolved Hide resolved
@GSadee GSadee added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jan 13, 2020
@AdamKasp AdamKasp force-pushed the navigation-CM-refund-order branch from 592d598 to 7bd9ed7 Compare January 13, 2020 13:57
@AdamKasp AdamKasp changed the title [WIP] Navigation cm-refund-order Navigation via breadcrumbs between credit memo - Order and refund page - order Jan 13, 2020
@AdamKasp AdamKasp force-pushed the navigation-CM-refund-order branch from 7bd9ed7 to 8bedf7c Compare January 13, 2020 15:22
lchrusciel
lchrusciel approved these changes Jan 13, 2020
View reviewed changes
src/Resources/config/app/config.yml Outdated Show resolved Hide resolved
src/Resources/config/app/config.yml Outdated Show resolved Hide resolved
src/Resources/views/Order/Grid/Field/number.html.twig Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the navigation-CM-refund-order branch from 8bedf7c to 0ad2fce Compare January 14, 2020 07:22
@AdamKasp AdamKasp force-pushed the navigation-CM-refund-order branch from 0ad2fce to 00c6a35 Compare January 14, 2020 08:34
@GSadee GSadee merged commit d3363aa into Sylius:master Jan 14, 2020
@GSadee
Copy link
Member

GSadee commented Jan 14, 2020

Thank you, Adam! 🎉

@GSadee GSadee mentioned this pull request Jan 14, 2020
Merged
lchrusciel added a commit that referenced this pull request Jan 14, 2020
@lchrusciel
minor #174 [CreditMemo] Remove unused service from credit memo genera…
3f2640a 
…tor (GSadee)

This PR was merged into the 1.0-dev branch.

Discussion
----------

After #172 

Commits
-------

8d2f7a8 [CreditMemo] Remove unused service from credit memo generator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamKasp @GSadee @lchrusciel @Tomanhez @Zales0123