Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for Sylius 1.8 & 1.9 and Symfony 4.4 & 5.2 #254

Merged
merged 12 commits into from
Feb 17, 2021
Merged

Allow for Sylius 1.8 & 1.9 and Symfony 4.4 & 5.2 #254

merged 12 commits into from
Feb 17, 2021

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Feb 10, 2021

No description provided.

@pamil pamil requested a review from a team as a code owner February 10, 2021 16:34
@pamil pamil force-pushed the master-sf4452-syl1819 branch 7 times, most recently from 2b2d213 to 1ce529d Compare February 10, 2021 17:00
@GSadee GSadee force-pushed the master-sf4452-syl1819 branch 2 times, most recently from 3ae8c44 to 5213a86 Compare February 15, 2021 07:09
@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Feb 15, 2021
@GSadee GSadee force-pushed the master-sf4452-syl1819 branch from 3154dd1 to 1183daf Compare February 15, 2021 10:16
Tomanhez
Tomanhez reviewed Feb 15, 2021
View reviewed changes
.github/workflows/build.yml Show resolved Hide resolved
src/DependencyInjection/Configuration.php Outdated Show resolved Hide resolved
@GSadee GSadee force-pushed the master-sf4452-syl1819 branch from 1183daf to 853f9ff Compare February 15, 2021 12:32
lchrusciel
lchrusciel reviewed Feb 15, 2021
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought. I assume the changes to the doctrine and twig namespaces are not treated as BC breaks? Are we sure, these will be used?

pamil
pamil commented Feb 16, 2021
View reviewed changes
Copy link
Contributor Author

@pamil pamil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd approve it if I could :)

.github/workflows/build.yml Outdated Show resolved Hide resolved
@GSadee GSadee force-pushed the master-sf4452-syl1819 branch from 5519cf9 to ad898fd Compare February 16, 2021 13:57
@lchrusciel lchrusciel mentioned this pull request Feb 17, 2021
Closed
@GSadee GSadee merged commit 6d5338e into Sylius:master Feb 17, 2021
@GSadee
Copy link
Member

GSadee commented Feb 17, 2021

Thanks, Kamil! 🥇

@GSadee GSadee mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomanhez Tomanhez Tomanhez left review comments

@GSadee GSadee GSadee left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pamil @GSadee @lchrusciel @Tomanhez