[Cart][Core] Rework the logic behind the cart #5565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Jul 21, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | #5197 |
| License | MIT |
| try { | ||
| $cart = $this->cartContext->getCart(); | ||
| } catch (CartNotFoundException $exception) { | ||
| $cart = null; |
Arminek
force-pushed
the
experimental/cart-providing-refactoring
branch
from
01e2f5f to
874ca1c
Compare
|
To have it more visible. Any chances / maybe it is worked on multiple orders per cart? #5566 |
|
@Mr-Negative IMO we should rework basic cart logic I don't think that multiple orders are our goal now. |
Arminek
force-pushed
the
experimental/cart-providing-refactoring
branch
from
24e671b to
e2aef46
Compare
| @@ -57,4 +63,5 @@ | |||
| </call> | |||
| </service> | |||
| </services> | |||
|
|
|||
Arminek
force-pushed
the
experimental/cart-providing-refactoring
branch
from
37567b3 to
1d987fa
Compare
Arminek
force-pushed
the
experimental/cart-providing-refactoring
branch
12 times, most recently
from
6314dcc to
ac2ec89
Compare
| @@ -58,19 +58,19 @@ protected function getCartSummaryRoute() | |||
| protected function getCurrentCart() | |||
| { | |||
| return $this | |||
| ->getProvider() | |||
| ->getContext() | |||
| ->getCart() | |||
| ; | |||
There was a problem hiding this comment.
I guess we can make it an one-liner.
|
Great job! Thanks @pjedrzejewski and @Arminek! 👍 |
|
@Arminek please apply all comments in a separate PR. |
| @@ -36,39 +40,40 @@ function it_is_initializable() | |||
| } | |||
|
|
|||
| function it_recalculates_cart_for_logged_in_user( | |||
| CartProviderInterface $cartProvider, | |||
| CartContextInterface $cartContext, | |||
| Event $event, | |||
| OrderInterface $order, | |||
| OrderRecalculatorInterface $orderRecalculator | |||
There was a problem hiding this comment.
Should be the second one (it's the collaborator injected into constructor).
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ng-refactoring [Cart][Core] Rework the logic behind the cart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.