[Channel] Add not blank validation for channel default currency #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arminek
commented
Jul 25, 2016
Arminek
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | #5565 |
| License | MIT |
| @@ -86,6 +86,14 @@ public function chooseDefaultTaxZone($taxZone) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function chooseDefaultLocale($locale) | |||
| { | |||
| // $this->getElement('default_locale')->selectOption($locale); | |||
Arminek
force-pushed
the
not-nullable-default-currency-on-channel
branch
5 times, most recently
from
799b87b to
f4cedce
Compare
Arminek
changed the title
Arminek
force-pushed
the
not-nullable-default-currency-on-channel
branch
from
f4cedce to
010c03a
Compare
| @@ -13,7 +13,7 @@ Feature: Channel validation | |||
| When I name it "Mobile channel" | |||
| But I do not specify its code | |||
| And I try to add it | |||
| Then I should be notified that code is required | |||
| Then I should be notified that "code" is required | |||
Arminek
force-pushed
the
not-nullable-default-currency-on-channel
branch
3 times, most recently
from
5943b0a to
2ccde64
Compare
| @@ -6,12 +6,14 @@ Feature: Adding a new channel | |||
|
|
|||
| Background: | |||
| Given I am logged in as an administrator | |||
| And the store has currency "Euro" | |||
There was a problem hiding this comment.
Given the store has currency "Euro"
And I am logged in as an administrator
At the beginning we should configure shop and login after everything is setup (we follow this convention everywhere).
|
👍, the same will need to be done for channel's default locale |
Arminek
force-pushed
the
not-nullable-default-currency-on-channel
branch
from
2ccde64 to
d740ad6
Compare
|
Good job! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.