Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SABnzbd to 3.3.1. Update Unrar to 6.0.1. #4658

Closed
wants to merge 2 commits into from

Conversation

Safihre
Copy link
Contributor

@Safihre Safihre commented Jun 1, 2021

The build on GA fails due to squidguard being unable to fetch a dependency from Sourceforge.

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

@Safihre Safihre changed the title Update SABnzbd to 3.3.0. Update Unrar to 6.0.1. Update SABnzbd to 3.3.1. Update Unrar to 6.0.1. Jun 19, 2021
@Safihre
Copy link
Contributor Author

Safihre commented Jun 20, 2021

@hgy59 Could you maybe review?
The build on GA fails due to squidguard being unable to fetch a dependency from Sourceforge.

@Safihre
Copy link
Contributor Author

Safihre commented Jun 27, 2021

@hgy59 @th0ma7 how do I make this DSM 7 ready?
Is it only the folders?
Is there some examples of using resource files for the shares? And how do I get the paths to those resources in the ini file so Sab wil use it?

@th0ma7
Copy link
Contributor

th0ma7 commented Jun 27, 2021

@Safihre Actually there are a few.. details are in the remarks section of this PR #4524 where you'll be able to find many examples from the check marks.

Main ones to check first check for are: the usual build fix for dsm7 due to gcc 7.3 compiler bug (not all packages needs it):

ifeq ($(call version_ge, ${TCVERSION}, 7.0),1)
CMAKE_ARGS += -DCMAKE_CXX_FLAGS=-D_GLIBCXX_USE_C99_MATH
endif

and the usual ${SYNOPKG_PKGVAR} in src/service-setup.sh which points to /var/packages/<package>/var which previously was ${SYNOPKG_PKGDEST}/var which was pointing to /var/packages/<package>/target/var

@hgy59
Copy link
Contributor

hgy59 commented Jun 27, 2021

@hgy59 @th0ma7 how do I make this DSM 7 ready?
Is it only the folders?
Is there some examples of using resource files for the shares? And how do I get the paths to those resources in the ini file so Sab wil use it?

Example code is in my #4627 for kiwix. The created share is not used by the service, so no need to store the path in any config file.

  • SERVICE_WIZARD_SHARE_NAME is introcuded here for shares by name to distinguish from SERVICE_WIZARD_SHARE.
  • the resouce file must contain the name of the share only.
  • such shares are created by DSM on the fly (and I suppose those are available in postinst)
  • DSM 7 creates a link to the share in package folder: /var/packages/{packache-name}/shares/{share-name}, but this is missing with DSM6.
    since 7.0-41201, package center will create a symlink under /var/packages/[package_id]/shares/ named by share folder pointing to share folder path.

My work so far for the second question:

# parameters:
# $1 name of a share
# result:
# prints the path of the share (if exists)
get_path_of_share_name ()
{
    synoshare --get ${1} | grep "Path" | sed 's|.*Path.*\[\(.*\)\]|\1|g'
}

@Safihre
Copy link
Contributor Author

Safihre commented Jul 4, 2021

@hgy59 Would it be possible to merge this and just publish it for DSM 6? It seems also from the recent discussions in #4524 that the shared resources approach we want to take for downloaders and Sonarr/Radarr/etc isn't ready yet.
And I would still like to get this to the end-users.

@Safihre
Copy link
Contributor Author

Safihre commented Jul 20, 2021

@SynoCommunity/developers Can anyone please tell me what to do with this PR to get it merged and published? It's been open for 1.5 month and it's just a small update.

@publicarray
Copy link
Member

publicarray commented Jul 21, 2021

Sorry I was away for a bit and there is so much to do with DSM7. I took this PR and made some changes on my branch to make it DSM7 compatible. Would you mind having a look? https://github.com/publicarray/spksrc/tree/sabnzbd330 I tried pushing it onto here but since I rebased from master I would need to force push.

@publicarray publicarray mentioned this pull request Jul 21, 2021
3 tasks
@Safihre
Copy link
Contributor Author

Safihre commented Aug 31, 2021

Superseded by #4748

@Safihre Safihre closed this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants