Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deluge, ffsync, rutorrent and squidguard build fixes #4695

Merged
merged 47 commits into from
Oct 1, 2021

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Jun 27, 2021

Motivation: Effort in order to remove build failures from master related to squidguard and friends. While at it adding multiple updates to dependencies. This PR is not intented to make the package to actually work on neither DSM6/7 but solely focus on removing build errors.
Linked issues: github action from #4658

Checklist

  • Build rule all-supported completed successfully
  • Package upgrade completed successfully
  • New installation of package completed successfully

ffsync

This project is no longer maintained.
This is now superseeded with a rust rewrite: mozilla-services/syncserver#165 (comment)
Project page: https://github.com/mozilla-services/syncstorage-rs/

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 27, 2021

@hgy59 feel free to chim-in. Going through a rough first pass.... slowly moving along.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 28, 2021

@hgy59 your help would be appreciated as there is one thing I do not get?
I have some code in cross/squid for unsupported archs but auto-builds still fails on them.
I re-used that same code into spk/squidguard but results stays the same.
Hints on solving this would be appreciated.

EDIT: adding include ../../mk/spksrc.common.mk did the trick. Problem solved.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Jun 29, 2021

@hgy59 I was finally able to solve all issues with cross-compiling and, you'll be happy to hear that I've removed native/squid as well.

Now, this package is obsolete on sooo many aspects that I don't know where to start with. Not even sure it can run as code looks like pre-DSM6. Help would be really much appreciated.

On the other hand I could also just push to master and leave it as-is for now and focus on other build failures where I think I can provide more benefits.

@th0ma7 th0ma7 requested review from hgy59 and ymartin59 June 29, 2021 12:23
@hgy59 hgy59 mentioned this pull request Jun 30, 2021
3 tasks
spk/squidguard/Makefile Outdated Show resolved Hide resolved
@th0ma7
Copy link
Contributor Author

th0ma7 commented Jul 4, 2021

It seems I have faced a blocker with this PR...
Updating c-ares leads to a need to update gevent which in turn was really really late in terms of used version.
And gevent fails and can't find a solution yet...
Help would be really much appreciated.

@hgy59 hgy59 mentioned this pull request Aug 31, 2021
3 tasks
@Safihre
Copy link
Contributor

Safihre commented Aug 31, 2021

Just noticed this one because of #4748, since squiguard has been in BETA = 1 since 2012 🙃, maybe this package can just be removed?

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 19, 2021

Just noticed this one because of #4748, since squiguard has been in BETA = 1 since 2012 upside_down_face, maybe this package can just be removed?

Good point @Safihre ... but I might have solved the latest build issues, fingers crossed :)

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

ffsync

This project is no longer maintained.
This is now superseeded with a rust rewrite: mozilla-services/syncserver#165 (comment)
Project page: https://github.com/mozilla-services/syncstorage-rs/

@hgy59 and @publicarray and others, I'm suggesting to retire the package until someone is willing to create a new one using the rust version.

@publicarray
Copy link
Member

I'm Ok with that I did a quick search and there are a few of open issues: #2985 #2748 #2093 #2816 #3124 #2747 #2828 #2873 wiki: https://github.com/SynoCommunity/spksrc/wiki/Firefox-Sync-Server-1.5

Before removing would you mind taking a look at #3849 first (might fix build issues or might not be worth the effort 🤷‍♂️ )?

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

@publicarray Wow, I should have noticed this first. My only intention with this PR is to remove build errors to get cleaner output from github-action. I'll see if can steal a few things from there as a start.

@publicarray
Copy link
Member

Haha yea most of the time Google (ddg or whatever) is a better Github search engine. Not this time though, a Github search that actually resurns something usefull 🤣

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

Woot! @publicarray finally got it to build! (not necessarily to work which would require additional changes from PR #3849)

@Safihre
Copy link
Contributor

Safihre commented Sep 21, 2021

@th0ma7 don't forget to merge in the master branch, for me that broke my builds...

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

don't forget to merge in the master branch, for me that broke my builds...

I'm sorry @Safihre I don't follow 🤷‍♂️ ? Indeed when all build errors are gone I'll ask for review and merge to master.

@Safihre
Copy link
Contributor

Safihre commented Sep 21, 2021

don't forget to merge in the master branch, for me that broke my builds...

I'm sorry @Safihre I don't follow 🤷‍♂️ ? Indeed when all build errors are gone I'll ask for review and merge to master.

I mean to rebase your changes in this PR/branch on the current master branch, since this branch was split a long time ago.

@th0ma7 th0ma7 changed the title [WIP] squidguard build fixes squidguard, ffsync and deluge build fixes Sep 21, 2021
@th0ma7 th0ma7 requested review from hgy59 and publicarray September 21, 2021 13:27
@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

I mean to rebase your changes in this PR/branch on the current master branch, since this branch was split a long time ago.

Gotcha! Yeah, I did a rebase a few days ago but thnx for the reminder.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 21, 2021

@hgy59 and @publicarray finally got it to build successfully!!! woot! Ready for peer-review in hope to reduce the amount of false-positive on github-action.

Copy link
Member

@publicarray publicarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to see the green check marks :)

FYI 01-squidguardmgr.cgi.patch-DISABLE was renamed and is now disabled.

cross/squid/Makefile Outdated Show resolved Hide resolved
@th0ma7 th0ma7 changed the title squidguard, ffsync and deluge build fixes deluge, ffsync, rutorrent and squidguard build fixes Sep 29, 2021
@th0ma7 th0ma7 merged commit 1eb6846 into SynoCommunity:master Oct 1, 2021
@th0ma7 th0ma7 deleted the squidguard-fix branch October 1, 2021 11:39
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 1, 2021
@th0ma7 th0ma7 mentioned this pull request Oct 5, 2021
3 tasks
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 7, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 13, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 13, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 25, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Oct 27, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Nov 20, 2021
th0ma7 added a commit to th0ma7/spksrc that referenced this pull request Dec 8, 2021
@defaultsecurity
Copy link

Any prospects regarding ruTorrent?

@publicarray
Copy link
Member

Any prospects regarding ruTorrent?

Not that I'm aware of. The pr description is pretty clear on that:

This PR is not intented to make the package to actually work on neither DSM6/7 but solely focus on removing build errors.

I would consider better alternatives like download station or transmission

@gary555
Copy link

gary555 commented Mar 9, 2023

Has the status changed???

@th0ma7
Copy link
Contributor Author

th0ma7 commented Mar 9, 2023

AlexPresso pushed a commit to AlexPresso/spksrc that referenced this pull request Jan 30, 2025
)

* berkleydb: Update from version 6.2.23 to 6.2.32

* c_icap: Udpate from 0.2.2 to 0.5.8 and enable extra features

* squidclamav: Update from version 6.10 to 7.1

* squidguard: Update from version 1.5-beta to 1.6.0 from Debian src

* native/squid: Update from 3.1.22 to 5.0.4

* squid: Update from version 3.1.22 to 5.0.4

* squidguard: Bump version and add unsupported archs

* squid+squidguard: Fix incompatible arch mgmnt

* squidguard: Fix blacklists.tar.gz source URL

* squidguardmanager: Update from version 1.11 to 1.14

* libev: Update from version 4.22 to 4.33

* gevent: Update from version 1.2.2 to 21.1.2

* gevent: Do not use embed c-ares and libev (like previously)

* gevent: Update to version 21.8.0

* pip_py2: Update to latest python2 compatible version

* greenlet: Update to version 1.1.1 and use .tar.gz extension

* ffsync: Add cffi dependency but must be after gevent

* ffsync: Import requirements from PR SynoCommunity#3849 (thnx @ymartin59)

* libtorrent: Fix DSM6 gcc49 build issue by adding -std=c++11

* squid: Remove shell call for file & directory name

* squidguard: Use default installation path (e.g. target)

* squidguard: Fix installation path and remove redundant prefix

* squidguard: Remove unnecessary patch now that path issue is solved

* squidguardmgr: Remove old patch no longer needed with newer version

* squidguardmgr: Fix path to squid sbin

* squidguard: Require squidclamav to test-build through cross

* squidguard: Fix path in cgi and use STAGING_INSTALL_PREFIX

* squidguard: Image thumbnails now generated by the framework

* squidguard: www now located under var

* c-icap: Dynamically update the default provided conf file

* squidguard: Fix clamd configuration paths

* squidguard: Use the now default provided errorpage.css mime.conf

* squidclamav: Use default provided config and fix clamd.ctl

* squidguard: Adjust squidguard.conf.tpl paths

* squidguard: Fix squidguardmgr.conf paths

* squid: Fix configuration paths

* squidguard: Add missing target in path

* c-icap: Update from version 0.5.8 to 0.5.9

* c-icap: Forgot to update PLIST with new lib version

* libtorrent: Enable -std=c++11 by default (also fixes comcerto2k)

Co-authored-by: hgy59 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants