Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[maps-assignent-1] Basic steps to make maps refactorable #761

Merged
merged 6 commits into from
Aug 12, 2023

Conversation

CommanderStorm
Copy link
Member

First PR in the debugging/refactoring effort of #512

Proposed Changes (include Screenshots if possible)

  • sparated the overlay and roomfinder step
  • added tests for all added types
  • added tests for some subsystems

How to test this PR

  1. run the tests
  2. see if it compiles

How has this been tested?

  • see above

Checklist

  • I have updated the documentation / No need to update the documentation
  • I have run the linter

@github-actions
Copy link
Contributor

👋 Thank you for contributing. A staging environment for this PR for this change will be available shortly

github-actions bot added a commit that referenced this pull request Aug 11, 2023
@CommanderStorm CommanderStorm marked this pull request as ready for review August 12, 2023 17:58
@CommanderStorm CommanderStorm merged commit 5d7b1d0 into main Aug 12, 2023
@CommanderStorm CommanderStorm deleted the maps_refactoring branch August 12, 2023 18:25
github-actions bot added a commit that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant