Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HEAD request to /download (#14) and fix GET /download missing crate return 405 (#15) #16

Closed
wants to merge 2 commits into from
Closed

Add HEAD request to /download (#14) and fix GET /download missing crate return 405 (#15) #16

wants to merge 2 commits into from

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Aug 1, 2024

@TalRoni
Copy link
Owner

TalRoni commented Aug 4, 2024

Hi @rluvaton,
Thank you for your contribution to this repository.
If I'm not mistaken, in crates.io, the HEAD request is used as a fallback for all API calls. (see https://github.com/rust-lang/crates.io/blob/main/src/router.rs#L172) We might prefer to implement this behavior. What do you think?

@rluvaton
Copy link
Contributor Author

rluvaton commented Aug 4, 2024

I'm closing this as I split the PR into multiple different PRs.

@rluvaton rluvaton closed this Aug 4, 2024
@rluvaton rluvaton deleted the support-head-request-for-crate-and-fix-status-code branch August 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rluvaton @TalRoni