-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android UI doesn't support Portrait and is small #4
Comments
1 vote for portrait feature for android |
1 similar comment
1 vote for portrait feature for android |
…id projects which have not set targetSDK (crashed without it)
Hi guys, thanks for the feature request and your votes! Can you please test the 1.2.5 release a bit? On Android the viewfinder should auto-rotate according to the orientation. Also, I've made the viewfinder slightly larger. |
Hi EddyVerbruggen thank you for your release. doesnot rotate when scan my image scan scan success still rotate https://cloud.githubusercontent.com/assets/866304/4570595/8be2eec0-4f61-11e4-9539-518118014901.png |
…ning of non-QR codes didn't work
Hi @kwanchanok-wc thanks for testing this so quickly! The image will orientation may change left-to-right or top-to-bottom, but with verson 1.2.6 it will no longer rotate 90 degrees. This also fixes the problem where regular barcodes (not QR) weren't recognized in portrait mode. |
I just tried out the latest version 1.2.6 and when the view has opened, I get the following crash log:
I hope that helps to find the problem. |
@EddyVerbruggen thank you |
I also tested it on Samsung Galaxy Note 10.1 (GT-N8000) with Android 4.4.2, the previous BarcodeScanner plugin worked as expected, but rotating from Portrait to Landscape. The current version 1.2.6 is correctly showing in Portrait mode, but the view is showing the camera view stretched or distorted, like it would should it as Landscape. It works well on Samsung Galaxy Nexus S with Android 4.3 in Portrait mode. I am not sure what could be the problem here. |
@trancee thanks for the details, a few more questions:
|
i test on galaxy note Galaxy Note II GT-N7100 with android 4.3. |
@EddyVerbruggen the crashlog came from Samsung Galaxy Star (GT-S5282) with Android 4.1.2, it is small screen device (240 x 320 pixels). The Galaxy Note 10.1 can only scan the barcode, if I hold the barcode the opposite way. It is not easy to make it work, as when I move the barcode, it is reflected in the opposite direction in the camera. But once I get it in the view area, it can recognize it. |
Hi @trancee I've found a fix for 240x320 devices, I will create a 1.2.7 version real soon with this fix. I'm not entirely sure what the exact problem is with the note 10.1.. you can scan the barcode if you hold it correctly right? If there is a problem please make a screenshot to explain the trouble. I will wait for your reply a bit, otherwise relesae 1.2.7 within a few hours. Thanks! |
@EddyVerbruggen I just tried the new version 1.2.7 with the Galaxy Star, and although it does not crash at the beginning anymore, it does now not recognize the barcode. And after a while, it crashes again with the following log:
I also noticed the following line when I start the barcode plugin from the app:
Could it be possible that it can not auto focus anymore? Because I noticed the camera does not focus on the barcode but way back in the background and does not change the focus... |
@EddyVerbruggen sorry for the delay, I had to first figure out how to take a screenshot on the Galaxy Note 10.1 with KitKat :) ... Here is the link to the screenshot: Note how the barcode scanner is correctly in the Portrait mode, but the camera shows the picture in Landscape mode. |
Hmm, that may be a limitation of the camera in the Note 10.1, not sure we can help that. Do you need to hold you Note in landscape position to be able to scan a 2D barcode? |
Actually, it is not. Before I updated to your version of the BarcodeScanner plugin, I used the original one and it had that exact same issue on the Galaxy Star phone. With your version, it shows correctly now, but wrong on the Galaxy Note 10.1 (with the original plugin in Landscape mode it works fine). Also, my friend has the same problem on his devices, but not sure which one it is anymore (Nexus probably). |
Sorry I don't have a Note 10.1 so I need to get this clear: When holding the Note in portrait mode (with the red line horizontal and the camera view shows in landscape mode), can you scan a 2D barcode when holding that barcode horizontally (so underneath the red line)? If not, does scanning work if you hold the barcode vertically? |
Sorry, I did not answer your question previously. In that mode, I have to hold the barcode vertically for the scanner to recognize the code. It won't work if I hold it horizontally. |
OK, that's not good :) Is it possible for you to share your entire project with me? Including the AndroidManifest.xml etc? |
Unfortunately, I am not able to share the project. But I could set up a test project where the exact same problem occurs. I am using Cordova and Sencha Touch framework. Would that help? |
Yes it would be of tremendous help! |
I have added you to the repository. I confirm that the current APK there has the problem on my Galaxy Note 10.1. |
I'm having similar issues with the latest plugin (stretched, distorted image in portrait mode) on a samsung galaxy 7plus tablet. It worked fine in previous versions where it rotated into landscape for the scan. I'll keep checking in to see if there are new updates. In the meantime, is it possible to revert to a previous version, via cordova plugin add [email protected] ? |
@cgort Yes you can use https://github.com/Telerik-Verified-Plugins/[email protected] I will release a new version tomorrow btw. |
…ablets with default landscape orientation
…ablets with default landscape orientation
Eddy, the latest version (1.2.8) hangs on both the Galaxy7plus tablet running 4.0.4 and Galaxy Ace 2 phone running 4.1.2 that I'm testing with. My code simply does: |
OK, I found that if I use the syntax: cordova.plugins.barcodeScanner.scan(showScanResult, showScanError); the plugin gets kicked off correctly. However, on the tablet, it comes in upside down in portrait mode, and on the phone, the video preview is stretched a little vertically in portrait mode, so that when if finds a qr code, the overlay of the code with the outline and dots does not line up with the video of the code. If the phone is held in landscape, the video seems correct, but the overlay comes in stretched horizontally. |
Any update on these last bugs? |
…id projects which have not set targetSDK (crashed without it)
…ning of non-QR codes didn't work
…ablets with default landscape orientation
…ablets with default landscape orientation
Make scanning on iOS a little bit more robust
Image upside down on tablet #20 Android UI doesn't support Portrait and is small #4 Prebuilt Zebra Crossing (xzing) Library #3 Forcing landscape on camera android #17 And also fixes these issues found here (possibly others as well): Android Nexus 5x upside down images phonegap/phonegap-plugin-barcodescanner#175 Support Aztec for Android and Ios phonegap/phonegap-plugin-barcodescanner#195 Android: Force landscape orientation? phonegap/phonegap-plugin-barcodescanner#177 Android M issues. Due to new intent/permissions phonegap/phonegap-plugin-barcodescanner#167 Problem with Android 6.0.1 phonegap/phonegap-plugin-barcodescanner#139 Is the zxing version used years away from the original zxing lib? phonegap/phonegap-plugin-barcodescanner#124 Updating ZXing Library phonegap/phonegap-plugin-barcodescanner#59
We are using this in a portrait application currently. On iOS it loads correctly and doesn't rotate the screen. On Android it always rotates the screen and loads a lot smaller selection box. It would be great if they could both load a similar UI and use the orientation of the device.
Here are what they look like on my devices currently
iPhone 6 Plus (https://www.dropbox.com/s/qb0yvgci7gewfmk/2014-10-01%2011.43.30.png?dl=0)
Nexus 5 (https://www.dropbox.com/s/w66eo7lwyth8si9/2014-10-01%2001.45.15.png?dl=0)
UPDATE:
I have noticed that these have been raised on the original plugin as well
wildabeast#120
wildabeast#70
wildabeast#44
The text was updated successfully, but these errors were encountered: