fix: incorrect thrown exception when calling Path.GetFullPath with …

…white-space (#1030) Throw the correct `ArgumentException` instead of a `NullReferenceException` when calling Path.GetFullPath with a WhiteSpace string.
TestableIO · Aug 25, 2023 · 00fb310 · 00fb310
1 parent f0046b4
commit 00fb310
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockPath.cs b/src/TestableIO.System.IO.Abstractions.TestingHelpers/MockPath.cs
@@ -39,7 +39,7 @@ public override string GetFullPath(string path)
                 throw new ArgumentNullException(nameof(path), StringResources.Manager.GetString("VALUE_CANNOT_BE_NULL"));
             }
 
-            if (path.Length == 0)
+            if (string.IsNullOrWhiteSpace(path))
             {
                 throw CommonExceptions.PathIsNotOfALegalForm(nameof(path));
             }

diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockPathTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockPathTests.cs
@@ -266,6 +266,16 @@ public void GetFullPath_EmptyValue_ShouldThrowArgumentException()
             Assert.Throws<ArgumentException>(action);
         }
 
+        [Test]
+        public void GetFullPath_WithWhiteSpace_ShouldThrowArgumentException()
+        {
+            var mockFileSystem = new MockFileSystem();
+
+            TestDelegate action = () => mockFileSystem.Path.GetFullPath("  ");
+
+            Assert.Throws<ArgumentException>(action);
+        }
+
         [Test]
         public void GetFullPath_WithMultipleDirectorySeparators_ShouldReturnTheNormalizedForm()
         {